| Message ID | 1476467614-17148-1-git-send-email-jhugo@codeaurora.org |
|---|---|
| State | Accepted |
| Headers | show |
On 14/10/16 18:53, Jeffrey Hugo wrote: > ACPI v5.1 defined timer flag bit 2 as "Always-on". Update the test to > account for this. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/acpi/gtdt/gtdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/gtdt/gtdt.c b/src/acpi/gtdt/gtdt.c > index b5ee280..d1543c4 100644 > --- a/src/acpi/gtdt/gtdt.c > +++ b/src/acpi/gtdt/gtdt.c > @@ -53,11 +53,11 @@ static int gtdt_test1(fwts_framework *fw) > uint32_t i = 0, n; > const fwts_acpi_table_gtdt *gtdt = (const fwts_acpi_table_gtdt *)table->data; > > - if (gtdt->virtual_timer_flags & ~3) { > + if (gtdt->virtual_timer_flags & ~7) { > passed = false; > fwts_failed(fw, LOG_LEVEL_LOW, > "GTDTFlagReservedNonZero", > - "GTDT flag reserved bits 2 to 31 are non-zero, " > + "GTDT flag reserved bits 3 to 31 are non-zero, " > "instead got 0x%" PRIx32 ".", gtdt->virtual_timer_flags); > } > > Thanks Jeffrey Acked-by: Colin Ian King <colin.king@canonical.com>
On 2016年10月15日 01:53, Jeffrey Hugo wrote: > ACPI v5.1 defined timer flag bit 2 as "Always-on". Update the test to > account for this. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > src/acpi/gtdt/gtdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/gtdt/gtdt.c b/src/acpi/gtdt/gtdt.c > index b5ee280..d1543c4 100644 > --- a/src/acpi/gtdt/gtdt.c > +++ b/src/acpi/gtdt/gtdt.c > @@ -53,11 +53,11 @@ static int gtdt_test1(fwts_framework *fw) > uint32_t i = 0, n; > const fwts_acpi_table_gtdt *gtdt = (const fwts_acpi_table_gtdt *)table->data; > > - if (gtdt->virtual_timer_flags & ~3) { > + if (gtdt->virtual_timer_flags & ~7) { > passed = false; > fwts_failed(fw, LOG_LEVEL_LOW, > "GTDTFlagReservedNonZero", > - "GTDT flag reserved bits 2 to 31 are non-zero, " > + "GTDT flag reserved bits 3 to 31 are non-zero, " > "instead got 0x%" PRIx32 ".", gtdt->virtual_timer_flags); > } > > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/gtdt/gtdt.c b/src/acpi/gtdt/gtdt.c index b5ee280..d1543c4 100644 --- a/src/acpi/gtdt/gtdt.c +++ b/src/acpi/gtdt/gtdt.c @@ -53,11 +53,11 @@ static int gtdt_test1(fwts_framework *fw) uint32_t i = 0, n; const fwts_acpi_table_gtdt *gtdt = (const fwts_acpi_table_gtdt *)table->data; - if (gtdt->virtual_timer_flags & ~3) { + if (gtdt->virtual_timer_flags & ~7) { passed = false; fwts_failed(fw, LOG_LEVEL_LOW, "GTDTFlagReservedNonZero", - "GTDT flag reserved bits 2 to 31 are non-zero, " + "GTDT flag reserved bits 3 to 31 are non-zero, " "instead got 0x%" PRIx32 ".", gtdt->virtual_timer_flags); }
ACPI v5.1 defined timer flag bit 2 as "Always-on". Update the test to account for this. Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> --- src/acpi/gtdt/gtdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)