From patchwork Mon Oct 18 12:49:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Bengtsson X-Patchwork-Id: 68177 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 82F89B70EA for ; Mon, 18 Oct 2010 23:52:34 +1100 (EST) Received: from localhost ([127.0.0.1]:41848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7pCZ-0004dM-JW for incoming@patchwork.ozlabs.org; Mon, 18 Oct 2010 08:52:31 -0400 Received: from [140.186.70.92] (port=39103 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P7pBK-0004Ke-2b for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P7pBI-0002GN-J2 for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:51:13 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:44600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P7pBI-0002GI-DY for qemu-devel@nongnu.org; Mon, 18 Oct 2010 08:51:12 -0400 Received: by bwz6 with SMTP id 6so582487bwz.4 for ; Mon, 18 Oct 2010 05:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=wGTpfNv0EFYD8hU6pDGvO+VRa9kwfOzGl1xtzJgtVRE=; b=Wku6W6NuqwPUuB/hVReh03/A0x4VpHWJEqDYPMC+Ci9z98GkLGsMX3fpdJJn8N4XVM MLOEZoUWLbDp8dAC2/4Wz4ztYXy04Vkq+HbWAPG4dOuEWt/ts6Nr6vYKoXpfrlYvMt7D vCBJov1Nd+G1DiDcMN/7xZzVGFB2tDU7lNBPk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=gr+ZRXh6kjz04y3odIvyPfdk2ysRaJXl4rkjmbC3qgdSzhHf9DVzulUIaktOgIj0CW fGj6BEnL9tq/MwhOb6+6aL3uGOFuQ+z0FkQRgWutVE2eIkghgSfN+sk21OOSZvybuSiL wjNLZRADW80fADutT+gzsRSR4s38VzmtDY+90= Received: by 10.204.62.202 with SMTP id y10mr2077634bkh.120.1287406270589; Mon, 18 Oct 2010 05:51:10 -0700 (PDT) Received: from localhost.localdomain (store.iar.se [213.136.49.54]) by mx.google.com with ESMTPS id x13sm16837169bki.0.2010.10.18.05.51.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Oct 2010 05:51:10 -0700 (PDT) From: Johan Bengtsson To: qemu-devel@nongnu.org Date: Mon, 18 Oct 2010 14:49:36 +0200 Message-Id: <1287406176-13554-1-git-send-email-teofrastius@gmail.com> X-Mailer: git-send-email 1.7.0.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Johan Bengtsson Subject: [Qemu-devel] [PATCH] Fix bug in translation of REVSH X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The translation of REVSH shifted the low byte 8 steps left before performing an 8-bit sign extend, causing this part of the expression to alwas be 0. The fix for this is either to extend before shifting or switch to a 16-bit extend. I choose the former. Signed-off-by: Johan Bengtsson --- target-arm/translate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 652cac9..e2fa4df 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -253,8 +253,8 @@ static void gen_revsh(TCGv var) TCGv tmp = new_tmp(); tcg_gen_shri_i32(tmp, var, 8); tcg_gen_andi_i32(tmp, tmp, 0x00ff); - tcg_gen_shli_i32(var, var, 8); tcg_gen_ext8s_i32(var, var); + tcg_gen_shli_i32(var, var, 8); tcg_gen_or_i32(var, var, tmp); dead_tmp(tmp); }