| Message ID | 20161013034247.21603-3-bluemrp9@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Wed, 12 Oct 2016 20:42:47 -0700, Ryan Coe wrote: > Signed-off-by: Ryan Coe <bluemrp9@gmail.com> This is almost ready to go, but since I had some comments on PATCH 2/3, I'll give you the few minor comments I had on this patch as well. > diff --git a/DEVELOPERS b/DEVELOPERS > index 7a23c78..bd85c3b 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -1260,6 +1260,7 @@ F: package/python-pysnmp-mibs/ > F: package/python-tornado/ > > N: Ryan Coe <bluemrp9@gmail.com> > +F: package/inadyn/ > F: package/libite/ The change to the DEVELOPERS file should be part of a separate patch. > diff --git a/package/inadyn/Config.in b/package/inadyn/Config.in > index 65f6851..55894ae 100644 > --- a/package/inadyn/Config.in > +++ b/package/inadyn/Config.in > @@ -1,4 +1,6 @@ > config BR2_PACKAGE_INADYN > + select BR2_PACKAGE_LIBCONFUSE > + select BR2_PACKAGE_LIBITE Please put the select below the "depends on". As explained in the Buildroot documentation, we try to be consistent across all packages, by using the following order: bool depends on ... depends on ... select ... select ... > -INADYN_VERSION = 1.99.12 > -INADYN_SITE = https://github.com/troglobit/inadyn/releases/download/$(INADYN_VERSION) > -INADYN_SOURCE = inadyn-$(INADYN_VERSION).tar.xz > +INADYN_VERSION = v2.0 > +INADYN_SITE = $(call github,troglobit,inadyn,$(INADYN_VERSION)) > INADYN_LICENSE = GPLv2+ > INADYN_LICENSE_FILES = COPYING > +INADYN_AUTORECONF = YES > + > +# Needed for autoreconf to work properly, see ./autogen.sh > +define INADYN_FIXUP_M4_DIR > + mkdir $(@D)/m4 > +endef > +INADYN_POST_EXTRACT_HOOKS += INADYN_FIXUP_M4_DIR > + > +INADYN_DEPENDENCIES += host-pkgconf libconfuse libite Minor detail, but could you move this DEPENDENCIES line earlier, i.e right after the AUTORECONF = YES line, and use the = sign rather than += ? I've marked your patches 2/3 and 3/3 as "Changes Requested" in our patch tracking system. So could you send an updated version that takes into account the review comments? Otherwise, we will forget about those patches as they are no longer in our TODO-list of patches to be applied. Thanks a lot! Thomas
diff --git a/DEVELOPERS b/DEVELOPERS index 7a23c78..bd85c3b 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1260,6 +1260,7 @@ F: package/python-pysnmp-mibs/ F: package/python-tornado/ N: Ryan Coe <bluemrp9@gmail.com> +F: package/inadyn/ F: package/libite/ N: Ryan Wilkins <ryan@deadfrog.net> diff --git a/package/inadyn/Config.in b/package/inadyn/Config.in index 65f6851..55894ae 100644 --- a/package/inadyn/Config.in +++ b/package/inadyn/Config.in @@ -1,4 +1,6 @@ config BR2_PACKAGE_INADYN + select BR2_PACKAGE_LIBCONFUSE + select BR2_PACKAGE_LIBITE bool "inadyn" depends on BR2_USE_MMU # Uses fork() depends on !BR2_STATIC_LIBS # dlopen() diff --git a/package/inadyn/inadyn.hash b/package/inadyn/inadyn.hash index 940bd16..a4e60c9 100644 --- a/package/inadyn/inadyn.hash +++ b/package/inadyn/inadyn.hash @@ -1,2 +1,2 @@ -# From https://github.com/troglobit/inadyn/releases/download/1.99.12/inadyn-1.99.12.tar.xz.md5 -md5 a620c9eab9cd31c8923e7264b08376f3 inadyn-1.99.12.tar.xz +# Locally computed +sha256 763c53eb3856decfe8b921cab8a54b428b079a62264fbcf6c89690713d63529a inadyn-v2.0.tar.gz diff --git a/package/inadyn/inadyn.mk b/package/inadyn/inadyn.mk index cf071da..4885831 100644 --- a/package/inadyn/inadyn.mk +++ b/package/inadyn/inadyn.mk @@ -4,11 +4,19 @@ # ################################################################################ -INADYN_VERSION = 1.99.12 -INADYN_SITE = https://github.com/troglobit/inadyn/releases/download/$(INADYN_VERSION) -INADYN_SOURCE = inadyn-$(INADYN_VERSION).tar.xz +INADYN_VERSION = v2.0 +INADYN_SITE = $(call github,troglobit,inadyn,$(INADYN_VERSION)) INADYN_LICENSE = GPLv2+ INADYN_LICENSE_FILES = COPYING +INADYN_AUTORECONF = YES + +# Needed for autoreconf to work properly, see ./autogen.sh +define INADYN_FIXUP_M4_DIR + mkdir $(@D)/m4 +endef +INADYN_POST_EXTRACT_HOOKS += INADYN_FIXUP_M4_DIR + +INADYN_DEPENDENCIES += host-pkgconf libconfuse libite ifeq ($(BR2_PACKAGE_OPENSSL),y) INADYN_CONF_OPTS += --enable-openssl
Signed-off-by: Ryan Coe <bluemrp9@gmail.com> --- DEVELOPERS | 1 + package/inadyn/Config.in | 2 ++ package/inadyn/inadyn.hash | 4 ++-- package/inadyn/inadyn.mk | 14 +++++++++++--- 4 files changed, 16 insertions(+), 5 deletions(-)