diff mbox

[v6,17/17] dax: remove "depends on BROKEN" from FS_DAX_PMD

Message ID 20161012225022.15507-18-ross.zwisler@linux.intel.com
State Superseded, archived
Headers show

Commit Message

Ross Zwisler Oct. 12, 2016, 10:50 p.m. UTC
Now that DAX PMD faults are once again working and are now participating in
DAX's radix tree locking scheme, allow their config option to be enabled.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 fs/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Jan Kara Oct. 13, 2016, 3:42 p.m. UTC | #1
On Wed 12-10-16 16:50:22, Ross Zwisler wrote:
> Now that DAX PMD faults are once again working and are now participating in
> DAX's radix tree locking scheme, allow their config option to be enabled.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 2bc7ad7..b6f0fce 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -55,7 +55,6 @@ config FS_DAX_PMD
>  	depends on FS_DAX
>  	depends on ZONE_DEVICE
>  	depends on TRANSPARENT_HUGEPAGE
> -	depends on BROKEN
>  
>  endif # BLOCK
>  
> -- 
> 2.9.0
>
Aneesh Kumar K.V Oct. 17, 2016, 5:57 a.m. UTC | #2
Ross Zwisler <ross.zwisler@linux.intel.com> writes:

> Now that DAX PMD faults are once again working and are now participating in
> DAX's radix tree locking scheme, allow their config option to be enabled.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
>  fs/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index 2bc7ad7..b6f0fce 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -55,7 +55,6 @@ config FS_DAX_PMD
>  	depends on FS_DAX
>  	depends on ZONE_DEVICE
>  	depends on TRANSPARENT_HUGEPAGE
> -	depends on BROKEN
>  
>  endif # BLOCK


This series made dax_pmd_fault return VM_FAULT_FALLBACK in [PATCH v6 09/17] dax: remove dax_pmd_fault(). 
That essentially disable dax pmd for ext4. Any plans to fix that ?

-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara Oct. 17, 2016, 9:09 a.m. UTC | #3
On Mon 17-10-16 11:27:24, Aneesh Kumar K.V wrote:
> Ross Zwisler <ross.zwisler@linux.intel.com> writes:
> 
> > Now that DAX PMD faults are once again working and are now participating in
> > DAX's radix tree locking scheme, allow their config option to be enabled.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> >  fs/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/Kconfig b/fs/Kconfig
> > index 2bc7ad7..b6f0fce 100644
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -55,7 +55,6 @@ config FS_DAX_PMD
> >  	depends on FS_DAX
> >  	depends on ZONE_DEVICE
> >  	depends on TRANSPARENT_HUGEPAGE
> > -	depends on BROKEN
> >  
> >  endif # BLOCK
> 
> 
> This series made dax_pmd_fault return VM_FAULT_FALLBACK in [PATCH v6 09/17] dax: remove dax_pmd_fault(). 
> That essentially disable dax pmd for ext4. Any plans to fix that ?

I'm working on converting ext4 to the new iomap infrastructure. Once that
is done, it can use new DAX helpers for PMD faults easily.

								Honza
diff mbox

Patch

diff --git a/fs/Kconfig b/fs/Kconfig
index 2bc7ad7..b6f0fce 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -55,7 +55,6 @@  config FS_DAX_PMD
 	depends on FS_DAX
 	depends on ZONE_DEVICE
 	depends on TRANSPARENT_HUGEPAGE
-	depends on BROKEN
 
 endif # BLOCK