From patchwork Sun Oct 17 23:44:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 68100 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id E4F251008E1 for ; Mon, 18 Oct 2010 10:44:19 +1100 (EST) Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 2CE6DB70E7; Mon, 18 Oct 2010 10:44:13 +1100 (EST) Received: by localhost.localdomain (Postfix, from userid 1000) id 0DB54C31B6; Mon, 18 Oct 2010 10:44:13 +1100 (EST) Received: from neuling.org (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 050BDC2CAB; Mon, 18 Oct 2010 10:44:13 +1100 (EST) From: Michael Neuling To: "Nicholas A. Bellinger" Subject: Re: 64K PAGE_SIZE and arch/powerpc/kernel/vdso.c In-reply-to: <1287216239.9909.234.camel@haakon2.linux-iscsi.org> References: <1287216239.9909.234.camel@haakon2.linux-iscsi.org> Comments: In-reply-to "Nicholas A. Bellinger" message dated "Sat, 16 Oct 2010 01:03:59 -0700." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 MIME-Version: 1.0 Date: Mon, 18 Oct 2010 10:44:12 +1100 Message-ID: <7015.1287359052@neuling.org> Cc: Brian King , Tim Abbott , linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org > Greetings Linux-ppc64 folks, > > While trying to compile v2.6.36-rc8 with PAGE_SIZE=65536 I run into the > following compile failure w/ strict checking on a RHEL5.4 / gcc (GCC) > 4.1.2 20080704 (Red Hat 4.1.2-46) system: > > cc1: warnings being treated as errors > arch/powerpc/kernel/vdso.c:81: warning: alignment of ‘vdso_data_store’ > is greater than maximum object file alignment. Using 32768 > CC arch/powerpc/sysdev/msi_bitmap.o > make[1]: *** [arch/powerpc/kernel/vdso.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > > Any ideas folks..? It seems this broke it: commit abe1ee3a221d53778c3e58747bbec6e518e5471b Author: Tim Abbott Date: Sun Sep 20 18:14:15 2009 -0400 Use macros for .data.page_aligned section. This patch changes the remaining direct references to .data.page_aligned in C and assembly code to use the macros in include/linux/linkage.h. Backing out just that part of the change (see below) fixes it. FYI the error only occurs on gcc 4.1 and 4.2. 4.3 and greater is fine. Mikey diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c index 13002fe..c140fce 100644 --- a/arch/powerpc/kernel/vdso.c +++ b/arch/powerpc/kernel/vdso.c @@ -78,7 +78,7 @@ static int vdso_ready; static union { struct vdso_data data; u8 page[PAGE_SIZE]; -} vdso_data_store __page_aligned_data; +} vdso_data_store __attribute__((__section__(".data.page_aligned"))); struct vdso_data *vdso_data = &vdso_data_store.data; /* Format of the patch table */