diff mbox

[U-Boot,v1,1/1] ARM:SUNXI: Update DRAM clock for Olimex A20 boards

Message ID 20161011084431.24503-1-stefan.mavrodiev@gmail.com
State Accepted
Delegated to: Hans de Goede
Headers show

Commit Message

Stefan Mavrodiev Oct. 11, 2016, 8:44 a.m. UTC
Originally dram clock was set to 480MHz, but this behaves
unstable. To improve stability the clock is reduced to 384MHz

Signed-off-by: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>
---
 configs/A20-OLinuXino-Lime2_defconfig | 2 +-
 configs/A20-OLinuXino-Lime_defconfig  | 2 +-
 configs/A20-Olimex-SOM-EVB_defconfig  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Stefan Mavrodiev Oct. 27, 2016, 10:33 a.m. UTC | #1
Hi,

I've notice that you've reduced DRAM clock for Lime2 and Lime, but not 
for A20-SOM.

Is there any specific reason for this?


Regards,

Stefan Mavrodiev

Olimex LDT


On 10/11/2016 12:38 PM, Hans de Goede wrote:
> Hi,
>
> On 10/11/2016 10:44 AM, Stefan Mavrodiev wrote:
>> Originally dram clock was set to 480MHz, but this behaves
>> unstable. To improve stability the clock is reduced to 384MHz
>>
>> Signed-off-by: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>
>
> The exact same change is already in u-boot-sunxi/next, and I've already
> send out a pullreq to get this merged.
>
> Regards,
>
> Hans
>
>> ---
>>  configs/A20-OLinuXino-Lime2_defconfig | 2 +-
>>  configs/A20-OLinuXino-Lime_defconfig  | 2 +-
>>  configs/A20-Olimex-SOM-EVB_defconfig  | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/A20-OLinuXino-Lime2_defconfig 
>> b/configs/A20-OLinuXino-Lime2_defconfig
>> index 5688622..4751fe0 100644
>> --- a/configs/A20-OLinuXino-Lime2_defconfig
>> +++ b/configs/A20-OLinuXino-Lime2_defconfig
>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>  CONFIG_ARCH_SUNXI=y
>>  CONFIG_SPL_I2C_SUPPORT=y
>>  CONFIG_MACH_SUN7I=y
>> -CONFIG_DRAM_CLK=480
>> +CONFIG_DRAM_CLK=384
>>  CONFIG_MMC0_CD_PIN="PH1"
>>  CONFIG_USB0_VBUS_PIN="PC17"
>>  CONFIG_USB0_VBUS_DET="PH5"
>> diff --git a/configs/A20-OLinuXino-Lime_defconfig 
>> b/configs/A20-OLinuXino-Lime_defconfig
>> index c4f6e1a..024dc2d 100644
>> --- a/configs/A20-OLinuXino-Lime_defconfig
>> +++ b/configs/A20-OLinuXino-Lime_defconfig
>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>  CONFIG_ARCH_SUNXI=y
>>  CONFIG_SPL_I2C_SUPPORT=y
>>  CONFIG_MACH_SUN7I=y
>> -CONFIG_DRAM_CLK=480
>> +CONFIG_DRAM_CLK=384
>>  CONFIG_MMC0_CD_PIN="PH1"
>>  CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime"
>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>> diff --git a/configs/A20-Olimex-SOM-EVB_defconfig 
>> b/configs/A20-Olimex-SOM-EVB_defconfig
>> index 7a14a7b..3f4e90d 100644
>> --- a/configs/A20-Olimex-SOM-EVB_defconfig
>> +++ b/configs/A20-Olimex-SOM-EVB_defconfig
>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>  CONFIG_ARCH_SUNXI=y
>>  CONFIG_SPL_I2C_SUPPORT=y
>>  CONFIG_MACH_SUN7I=y
>> -CONFIG_DRAM_CLK=480
>> +CONFIG_DRAM_CLK=384
>>  CONFIG_MMC0_CD_PIN="PH1"
>>  CONFIG_MMC3_CD_PIN="PH0"
>>  CONFIG_MMC3_PINS="PH"
>>
Hans de Goede Oct. 29, 2016, 12:35 p.m. UTC | #2
Hi,

On 27-10-16 12:33, Stefan Mavrodiev wrote:
> Hi,
>
> I've notice that you've reduced DRAM clock for Lime2 and Lime, but not for A20-SOM.
>
> Is there any specific reason for this?

Sorry, as I mentioned I had received a patch similar to
yours and I had already merged that patch. I did not
notice that your patch also modified the A20-SOM
where as the patch I merged did not.

I've added the A20-SOM part of your patch (with you
as the author) to my tree now and will include it
in my next pull-req.

Regards,

Hans


>
>
> Regards,
>
> Stefan Mavrodiev
>
> Olimex LDT
>
>
> On 10/11/2016 12:38 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 10/11/2016 10:44 AM, Stefan Mavrodiev wrote:
>>> Originally dram clock was set to 480MHz, but this behaves
>>> unstable. To improve stability the clock is reduced to 384MHz
>>>
>>> Signed-off-by: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>
>>
>> The exact same change is already in u-boot-sunxi/next, and I've already
>> send out a pullreq to get this merged.
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>>  configs/A20-OLinuXino-Lime2_defconfig | 2 +-
>>>  configs/A20-OLinuXino-Lime_defconfig  | 2 +-
>>>  configs/A20-Olimex-SOM-EVB_defconfig  | 2 +-
>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig
>>> index 5688622..4751fe0 100644
>>> --- a/configs/A20-OLinuXino-Lime2_defconfig
>>> +++ b/configs/A20-OLinuXino-Lime2_defconfig
>>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>>  CONFIG_ARCH_SUNXI=y
>>>  CONFIG_SPL_I2C_SUPPORT=y
>>>  CONFIG_MACH_SUN7I=y
>>> -CONFIG_DRAM_CLK=480
>>> +CONFIG_DRAM_CLK=384
>>>  CONFIG_MMC0_CD_PIN="PH1"
>>>  CONFIG_USB0_VBUS_PIN="PC17"
>>>  CONFIG_USB0_VBUS_DET="PH5"
>>> diff --git a/configs/A20-OLinuXino-Lime_defconfig b/configs/A20-OLinuXino-Lime_defconfig
>>> index c4f6e1a..024dc2d 100644
>>> --- a/configs/A20-OLinuXino-Lime_defconfig
>>> +++ b/configs/A20-OLinuXino-Lime_defconfig
>>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>>  CONFIG_ARCH_SUNXI=y
>>>  CONFIG_SPL_I2C_SUPPORT=y
>>>  CONFIG_MACH_SUN7I=y
>>> -CONFIG_DRAM_CLK=480
>>> +CONFIG_DRAM_CLK=384
>>>  CONFIG_MMC0_CD_PIN="PH1"
>>>  CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime"
>>>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>>> diff --git a/configs/A20-Olimex-SOM-EVB_defconfig b/configs/A20-Olimex-SOM-EVB_defconfig
>>> index 7a14a7b..3f4e90d 100644
>>> --- a/configs/A20-Olimex-SOM-EVB_defconfig
>>> +++ b/configs/A20-Olimex-SOM-EVB_defconfig
>>> @@ -2,7 +2,7 @@ CONFIG_ARM=y
>>>  CONFIG_ARCH_SUNXI=y
>>>  CONFIG_SPL_I2C_SUPPORT=y
>>>  CONFIG_MACH_SUN7I=y
>>> -CONFIG_DRAM_CLK=480
>>> +CONFIG_DRAM_CLK=384
>>>  CONFIG_MMC0_CD_PIN="PH1"
>>>  CONFIG_MMC3_CD_PIN="PH0"
>>>  CONFIG_MMC3_PINS="PH"
>>>
>
diff mbox

Patch

diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig
index 5688622..4751fe0 100644
--- a/configs/A20-OLinuXino-Lime2_defconfig
+++ b/configs/A20-OLinuXino-Lime2_defconfig
@@ -2,7 +2,7 @@  CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_MACH_SUN7I=y
-CONFIG_DRAM_CLK=480
+CONFIG_DRAM_CLK=384
 CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_USB0_VBUS_PIN="PC17"
 CONFIG_USB0_VBUS_DET="PH5"
diff --git a/configs/A20-OLinuXino-Lime_defconfig b/configs/A20-OLinuXino-Lime_defconfig
index c4f6e1a..024dc2d 100644
--- a/configs/A20-OLinuXino-Lime_defconfig
+++ b/configs/A20-OLinuXino-Lime_defconfig
@@ -2,7 +2,7 @@  CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_MACH_SUN7I=y
-CONFIG_DRAM_CLK=480
+CONFIG_DRAM_CLK=384
 CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
diff --git a/configs/A20-Olimex-SOM-EVB_defconfig b/configs/A20-Olimex-SOM-EVB_defconfig
index 7a14a7b..3f4e90d 100644
--- a/configs/A20-Olimex-SOM-EVB_defconfig
+++ b/configs/A20-Olimex-SOM-EVB_defconfig
@@ -2,7 +2,7 @@  CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_MACH_SUN7I=y
-CONFIG_DRAM_CLK=480
+CONFIG_DRAM_CLK=384
 CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_MMC3_CD_PIN="PH0"
 CONFIG_MMC3_PINS="PH"