Patchwork PATCH for Re: -finline-functions default with -Os ?

login
register
mail settings
Submitter Gerald Pfeifer
Date Oct. 17, 2010, 5:04 p.m.
Message ID <alpine.LNX.2.00.1010171858350.2945@acrux.dbai.tuwien.ac.at>
Download mbox | patch
Permalink /patch/68086/
State New
Headers show

Comments

Gerald Pfeifer - Oct. 17, 2010, 5:04 p.m.
[ gcc -> gcc-patches ]

On Sat, 3 Jul 2010, Steven Bosscher wrote:
> 2010/7/3 Frédéric L. W. Meunier <fredlwm@gmail.com>:
>> Here, -finline-functions appears to be the default using -Os with GCC 
>> 4.4.4 on Linux (tested with k8-sse3 and 486).
>>
>> But according to the man page, "Enabled at level -O3". Does the manual 
>> need a fix ?
> 
> Yes, it should say "Enabled at levels -O3 and -Os".

Hmm, somehow I just see nobody has made this fix?

Would something like the following be appropriate?  I checked opts.c,
and that agrees with your assessment.



(On a tangent, I am a bit puzzled why we would enable something at
-O3 and -Os, but not -O2?)

Gerald


2010-10-17  Gerald Pfeifer  <gerald@pfeifer.com>

	* doc/invoke.texi (-finline-functions): Is also enabled at -Os.
Richard Guenther - Oct. 18, 2010, 9:15 a.m.
2010/10/17 Gerald Pfeifer <gerald@pfeifer.com>:
> [ gcc -> gcc-patches ]
>
> On Sat, 3 Jul 2010, Steven Bosscher wrote:
>> 2010/7/3 Frédéric L. W. Meunier <fredlwm@gmail.com>:
>>> Here, -finline-functions appears to be the default using -Os with GCC
>>> 4.4.4 on Linux (tested with k8-sse3 and 486).
>>>
>>> But according to the man page, "Enabled at level -O3". Does the manual
>>> need a fix ?
>>
>> Yes, it should say "Enabled at levels -O3 and -Os".
>
> Hmm, somehow I just see nobody has made this fix?
>
> Would something like the following be appropriate?  I checked opts.c,
> and that agrees with your assessment.

I think rather than this it would be more sensible to not enable
-finline-functions at -Os but only -finline-small-functions (which is
basically what -finline-functions does at -Os).

Richard.

>
>
> (On a tangent, I am a bit puzzled why we would enable something at
> -O3 and -Os, but not -O2?)
>
> Gerald
>
>
> 2010-10-17  Gerald Pfeifer  <gerald@pfeifer.com>
>
>        * doc/invoke.texi (-finline-functions): Is also enabled at -Os.
>
> Index: doc/invoke.texi
> ===================================================================
> --- doc/invoke.texi     (revision 165562)
> +++ doc/invoke.texi     (working copy)
> @@ -6043,7 +6043,7 @@
>  declared @code{static}, then the function is normally not output as
>  assembler code in its own right.
>
> -Enabled at level @option{-O3}.
> +Enabled at level @option{-O3} and @option{-Os}.
>
>  @item -finline-functions-called-once
>  @opindex finline-functions-called-once

Patch

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi	(revision 165562)
+++ doc/invoke.texi	(working copy)
@@ -6043,7 +6043,7 @@ 
 declared @code{static}, then the function is normally not output as
 assembler code in its own right.
 
-Enabled at level @option{-O3}.
+Enabled at level @option{-O3} and @option{-Os}.
 
 @item -finline-functions-called-once
 @opindex finline-functions-called-once