diff mbox

[U-Boot,2/3] ti: common: board_detect: Setup initial default value for config as well

Message ID 20161011173905.26208-3-nm@ti.com
State Accepted
Commit 2a78c9e7196ff49bdf53d0b88b49b5eb337461fe
Delegated to: Tom Rini
Headers show

Commit Message

Nishanth Menon Oct. 11, 2016, 5:39 p.m. UTC
config should have been initialized along with others as defaults.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 board/ti/common/board_detect.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lokesh Vutla Oct. 13, 2016, 3:45 a.m. UTC | #1
On Tuesday 11 October 2016 11:09 PM, Nishanth Menon wrote:
> config should have been initialized along with others as defaults.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> ---
>  board/ti/common/board_detect.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c
> index 7c552d20656a..13aac2f03037 100644
> --- a/board/ti/common/board_detect.c
> +++ b/board/ti/common/board_detect.c
> @@ -131,6 +131,7 @@ int __maybe_unused ti_i2c_eeprom_am_get(int bus_addr, int dev_addr)
>  	ep->name[0] = 0x0;
>  	ep->version[0] = 0x0;
>  	ep->serial[0] = 0x0;
> +	ep->config[0] = 0x0;
>  
>  	rc = ti_i2c_eeprom_get(bus_addr, dev_addr, TI_EEPROM_HEADER_MAGIC,
>  			       sizeof(am_ep), (uint8_t *)&am_ep);
> @@ -175,6 +176,7 @@ int __maybe_unused ti_i2c_eeprom_dra7_get(int bus_addr, int dev_addr)
>  	ep->name[0] = 0x0;
>  	ep->version[0] = 0x0;
>  	ep->serial[0] = 0x0;
> +	ep->config[0] = 0x0;
>  	ep->emif1_size = 0;
>  	ep->emif2_size = 0;
>  
>
Tom Rini Oct. 13, 2016, 1:43 p.m. UTC | #2
On Tue, Oct 11, 2016 at 12:39:04PM -0500, Nishanth Menon wrote:

> config should have been initialized along with others as defaults.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Nov. 2, 2016, 2:26 p.m. UTC | #3
On Tue, Oct 11, 2016 at 12:39:04PM -0500, Nishanth Menon wrote:

> config should have been initialized along with others as defaults.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master (before v2016.11-rc3), thanks!
diff mbox

Patch

diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c
index 7c552d20656a..13aac2f03037 100644
--- a/board/ti/common/board_detect.c
+++ b/board/ti/common/board_detect.c
@@ -131,6 +131,7 @@  int __maybe_unused ti_i2c_eeprom_am_get(int bus_addr, int dev_addr)
 	ep->name[0] = 0x0;
 	ep->version[0] = 0x0;
 	ep->serial[0] = 0x0;
+	ep->config[0] = 0x0;
 
 	rc = ti_i2c_eeprom_get(bus_addr, dev_addr, TI_EEPROM_HEADER_MAGIC,
 			       sizeof(am_ep), (uint8_t *)&am_ep);
@@ -175,6 +176,7 @@  int __maybe_unused ti_i2c_eeprom_dra7_get(int bus_addr, int dev_addr)
 	ep->name[0] = 0x0;
 	ep->version[0] = 0x0;
 	ep->serial[0] = 0x0;
+	ep->config[0] = 0x0;
 	ep->emif1_size = 0;
 	ep->emif2_size = 0;