| Message ID | 1476128076-8875-1-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 10 Oct 2016 16:34:36 -0300 Eduardo Habkost <ehabkost@redhat.com> wrote: > TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't > need to set cannot_destroy_with_object_finalize_yet anymore. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > target-i386/cpu.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 1e8127b..33129db 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -3575,11 +3575,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) > cc->cpu_exec_exit = x86_cpu_exec_exit; > > dc->cannot_instantiate_with_device_add_yet = false; > - /* > - * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the > - * object in cpus -> dangling pointer after final object_unref(). > - */ > - dc->cannot_destroy_with_object_finalize_yet = true; > } > > static const TypeInfo x86_cpu_type_info = {
On Tue, Oct 11, 2016 at 01:37:07PM +0200, Igor Mammedov wrote: > On Mon, 10 Oct 2016 16:34:36 -0300 > Eduardo Habkost <ehabkost@redhat.com> wrote: > > > TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't > > need to set cannot_destroy_with_object_finalize_yet anymore. > > > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > Reviewed-by: Igor Mammedov <imammedo@redhat.com> Thanks. Applied to x86-next.
diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1e8127b..33129db 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3575,11 +3575,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) cc->cpu_exec_exit = x86_cpu_exec_exit; dc->cannot_instantiate_with_device_add_yet = false; - /* - * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the - * object in cpus -> dangling pointer after final object_unref(). - */ - dc->cannot_destroy_with_object_finalize_yet = true; } static const TypeInfo x86_cpu_type_info = {
TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't need to set cannot_destroy_with_object_finalize_yet anymore. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/cpu.c | 5 ----- 1 file changed, 5 deletions(-)