[mingw] : Keep inhibit_libc set to false on cross-compilation of mingw targets

Submitted by Dave Korn on Oct. 15, 2010, 11:11 p.m.

Details

Message ID 4CB8DF87.8020105@gmail.com
State New
Headers show

Commit Message

Dave Korn Oct. 15, 2010, 11:11 p.m.
On 15/10/2010 22:43, Kai Tietz wrote:

>>> +     case $target in
>>> +       *-*-mingw*)
>>> +          if test "x$with_headers" = x; then
>>> +             with_headers=yes
>>> +          fi
>>> +          ;;
>>> +       *)
>>> +          ;;
>>> +     esac
>>  No need to add a whole new case statement, if you want to match on target
>> only then match the pattern ",*-*-mingw*" in case "$host","$target" above.
> Well, this I thought first too, but then It would be just for x86_64
> host targetting i?86, which isn't what I want here.

  I don't see why that would happen?  I'm thinking of something like this:

$ diff -pu configure.ac .cf


which ought to be just the same as testing $target only.

    cheers,
      DaveK

Comments

Dave Korn Oct. 16, 2010, 2:52 a.m.
On 16/10/2010 00:11, Dave Korn wrote:

> $ diff -pu configure.ac .cf
> --- configure.ac        2010-10-14 05:10:03.359375000 +0100
> +++ .cf 2010-10-16 00:09:47.921875000 +0100
> @@ -1735,6 +1735,11 @@ then
>                 fi
>                 ;;
> 
> +           *,*-*-mingw*)
> +               if test "x$with_headers" = x; then
> +                   with_headers=yes
> +               fi
> +               ;;
>             i?86-*-*,x86_64-*-* \
>             | powerpc*-*-*,powerpc64*-*-*)
>                 CROSS="$CROSS -DNATIVE_CROSS" ;;
> 
> 
> which ought to be just the same as testing $target only.

  Yeah, actually that's too simplistic, it doesn't enable NATIVE_CROSS when it
could do.  By the time you added an extra clause for that case ... may as well
stick to your original plan.

    cheers,
      DaveK
Kai Tietz Oct. 16, 2010, 11 a.m.
2010/10/16 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 16/10/2010 00:11, Dave Korn wrote:
>
>> $ diff -pu configure.ac .cf
>> --- configure.ac        2010-10-14 05:10:03.359375000 +0100
>> +++ .cf 2010-10-16 00:09:47.921875000 +0100
>> @@ -1735,6 +1735,11 @@ then
>>                 fi
>>                 ;;
>>
>> +           *,*-*-mingw*)
>> +               if test "x$with_headers" = x; then
>> +                   with_headers=yes
>> +               fi
>> +               ;;
>>             i?86-*-*,x86_64-*-* \
>>             | powerpc*-*-*,powerpc64*-*-*)
>>                 CROSS="$CROSS -DNATIVE_CROSS" ;;
>>
>>
>> which ought to be just the same as testing $target only.
>
>  Yeah, actually that's too simplistic, it doesn't enable NATIVE_CROSS when it
> could do.  By the time you added an extra clause for that case ... may as well
> stick to your original plan.
>
>    cheers,
>      DaveK
>
>
>

Ok, applied patch at revision 165538.

Thanks,
Kai

Patch hide | download patch | download mbox

--- configure.ac        2010-10-14 05:10:03.359375000 +0100
+++ .cf 2010-10-16 00:09:47.921875000 +0100
@@ -1735,6 +1735,11 @@  then
                fi
                ;;

+           *,*-*-mingw*)
+               if test "x$with_headers" = x; then
+                   with_headers=yes
+               fi
+               ;;
            i?86-*-*,x86_64-*-* \
            | powerpc*-*-*,powerpc64*-*-*)
                CROSS="$CROSS -DNATIVE_CROSS" ;;