diff mbox

[U-Boot,11/11] x86: Clean up unused macros in the configuration headers

Message ID 1476011660-6780-12-git-send-email-bmeng.cn@gmail.com
State Accepted
Commit 00bcaedd5c4063c677d16af264bbcb991fb9675c
Delegated to: Bin Meng
Headers show

Commit Message

Bin Meng Oct. 9, 2016, 11:14 a.m. UTC
Legacy video driver macros are not needed. Clean them up.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

 include/configs/cougarcanyon2.h  |  4 ----
 include/configs/efi-x86.h        |  2 --
 include/configs/galileo.h        |  4 ----
 include/configs/x86-chromebook.h | 12 +++---------
 include/configs/x86-common.h     |  7 -------
 5 files changed, 3 insertions(+), 26 deletions(-)

Comments

Simon Glass Oct. 12, 2016, 12:06 a.m. UTC | #1
On 9 October 2016 at 05:14, Bin Meng <bmeng.cn@gmail.com> wrote:
> Legacy video driver macros are not needed. Clean them up.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>
> ---
>
>  include/configs/cougarcanyon2.h  |  4 ----
>  include/configs/efi-x86.h        |  2 --
>  include/configs/galileo.h        |  4 ----
>  include/configs/x86-chromebook.h | 12 +++---------
>  include/configs/x86-common.h     |  7 -------
>  5 files changed, 3 insertions(+), 26 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng Oct. 12, 2016, 3:10 a.m. UTC | #2
On Wed, Oct 12, 2016 at 8:06 AM, Simon Glass <sjg@chromium.org> wrote:
> On 9 October 2016 at 05:14, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Legacy video driver macros are not needed. Clean them up.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> ---
>>
>>  include/configs/cougarcanyon2.h  |  4 ----
>>  include/configs/efi-x86.h        |  2 --
>>  include/configs/galileo.h        |  4 ----
>>  include/configs/x86-chromebook.h | 12 +++---------
>>  include/configs/x86-common.h     |  7 -------
>>  5 files changed, 3 insertions(+), 26 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/include/configs/cougarcanyon2.h b/include/configs/cougarcanyon2.h
index 88845dc..d20ad96 100644
--- a/include/configs/cougarcanyon2.h
+++ b/include/configs/cougarcanyon2.h
@@ -27,8 +27,4 @@ 
 #define CONFIG_ENV_SECT_SIZE		0x1000
 #define CONFIG_ENV_OFFSET		0x5ff000
 
-/* Video is not supported for now */
-#undef CONFIG_VIDEO
-#undef CONFIG_CFB_CONSOLE
-
 #endif	/* __CONFIG_H */
diff --git a/include/configs/efi-x86.h b/include/configs/efi-x86.h
index 95e46c5..5626061 100644
--- a/include/configs/efi-x86.h
+++ b/include/configs/efi-x86.h
@@ -15,8 +15,6 @@ 
 
 #undef CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_ENV_IS_NOWHERE
-#undef CONFIG_VIDEO
-#undef CONFIG_CFB_CONSOLE
 #undef CONFIG_SCSI_AHCI
 #undef CONFIG_SCSI
 #undef CONFIG_INTEL_ICH6_GPIO
diff --git a/include/configs/galileo.h b/include/configs/galileo.h
index 40f7fba..034142c 100644
--- a/include/configs/galileo.h
+++ b/include/configs/galileo.h
@@ -31,10 +31,6 @@ 
 #undef CONFIG_SCSI_AHCI
 #undef CONFIG_SCSI
 
-/* Video is not supported in Quark SoC */
-#undef CONFIG_VIDEO
-#undef CONFIG_CFB_CONSOLE
-
 /* SD/MMC support */
 #define CONFIG_MMC
 #define CONFIG_SDHCI
diff --git a/include/configs/x86-chromebook.h b/include/configs/x86-chromebook.h
index 7fba716..4bcebfc 100644
--- a/include/configs/x86-chromebook.h
+++ b/include/configs/x86-chromebook.h
@@ -53,14 +53,8 @@ 
 
 #define CONFIG_SYS_WHITE_ON_BLACK
 
-#ifdef CONFIG_DM_VIDEO
-#define VIDEO_DEV "vidconsole"
-#else
-#define VIDEO_DEV "vga"
-#endif
-
-#define CONFIG_STD_DEVICES_SETTINGS     "stdin=usbkbd,i8042-kbd,serial\0" \
-					"stdout=" VIDEO_DEV ",serial\0" \
-					"stderr=" VIDEO_DEV ",serial\0"
+#define CONFIG_STD_DEVICES_SETTINGS	"stdin=usbkbd,i8042-kbd,serial\0" \
+					"stdout=vidconsole,serial\0" \
+					"stderr=vidconsole,serial\0"
 
 #endif
diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
index 96c53b8..3926541 100644
--- a/include/configs/x86-common.h
+++ b/include/configs/x86-common.h
@@ -131,13 +131,6 @@ 
 /*-----------------------------------------------------------------------
  * Video Configuration
  */
-#ifndef CONFIG_DM_VIDEO
-#define CONFIG_VIDEO
-#define CONFIG_VIDEO_SW_CURSOR
-#define VIDEO_FB_16BPP_WORD_SWAP
-#define CONFIG_VGA_AS_SINGLE_DEVICE
-#define CONFIG_CFB_CONSOLE
-#endif
 #define CONFIG_CONSOLE_SCROLL_LINES 5
 
 /*-----------------------------------------------------------------------