Message ID | 1287156047-17439-3-git-send-email-maximlevitsky@gmail.com |
---|---|
State | Accepted |
Commit | 480792b7bf188c29b8d4b10fee65c3a06ec5dbf7 |
Headers | show |
On Fri, Oct 15, 2010 at 05:20:44PM +0200, Maxim Levitsky wrote: > It not needed, because I already added locking for all fops > methods. > > Signed-off-by: Maxim Levitsky This SoB got damaged.
On Sat, 2010-10-16 at 07:12 +0200, Wolfram Sang wrote: > On Fri, Oct 15, 2010 at 05:20:44PM +0200, Maxim Levitsky wrote: > > It not needed, because I already added locking for all fops > > methods. > > > > Signed-off-by: Maxim Levitsky > > This SoB got damaged. > Should I resend it? Signed-of-by: Maxim Levitsky <maximlevitky@gmail.com> Best regards, Maxim Levitsky
On Sun, 2010-10-17 at 00:46 +0200, Maxim Levitsky wrote: > On Sat, 2010-10-16 at 07:12 +0200, Wolfram Sang wrote: > > On Fri, Oct 15, 2010 at 05:20:44PM +0200, Maxim Levitsky wrote: > > > It not needed, because I already added locking for all fops > > > methods. > > > > > > Signed-off-by: Maxim Levitsky > > > > This SoB got damaged. > > > > Should I resend it? > Signed-of-by: Maxim Levitsky <maximlevitky@gmail.com> Ideally yes, the maintainer ideally should be able to just git am your patch without having to copy-paste anything. Also, MTD subsystem's prefix is "mtd:".
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 352831b..040c2d9 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -181,7 +181,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) if (!dev) return -ERESTARTSYS; /* FIXME: busy loop! -arnd*/ - lock_kernel(); mutex_lock(&dev->lock); if (dev->open++) @@ -198,7 +197,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode) unlock: mutex_unlock(&dev->lock); blktrans_dev_put(dev); - unlock_kernel(); return ret; } @@ -210,7 +208,6 @@ static int blktrans_release(struct gendisk *disk, fmode_t mode) if (!dev) return ret; - lock_kernel(); mutex_lock(&dev->lock); if (--dev->open) @@ -226,7 +223,6 @@ static int blktrans_release(struct gendisk *disk, fmode_t mode) unlock: mutex_unlock(&dev->lock); blktrans_dev_put(dev); - unlock_kernel(); return ret; } @@ -259,7 +255,6 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode, if (!dev) return ret; - lock_kernel(); mutex_lock(&dev->lock); if (!dev->mtd) @@ -274,7 +269,6 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode, } unlock: mutex_unlock(&dev->lock); - unlock_kernel(); blktrans_dev_put(dev); return ret; }
It not needed, because I already added locking for all fops methods. Signed-off-by: Maxim Levitsky --- drivers/mtd/mtd_blkdevs.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)