| Message ID | 1475853518-22264-11-git-send-email-pantelis.antoniou@konsulko.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/07/2016 08:18 AM, Pantelis Antoniou wrote: > From: Georgi Vlaev <gvlaev@juniper.net> > > Add device tree bindings document for the SAM MDIO block > present in Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev <gvlaev@juniper.net> > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > --- > Documentation/devicetree/bindings/net/mdio-sam.txt | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/mdio-sam.txt > > diff --git a/Documentation/devicetree/bindings/net/mdio-sam.txt b/Documentation/devicetree/bindings/net/mdio-sam.txt > new file mode 100644 > index 0000000..7d354e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mdio-sam.txt > @@ -0,0 +1,48 @@ > +Juniper SAM FPGA MFD MDIO bus properties. > + > +Required properties: > +- compatible : "jnx,mdio-sam" > +- reg : The start offset of the MDIO bus range > +- #address-cells = <1>; > +- #size-cells = <0>; > + > +Optional properties: > + > +Required properties for child nodes: > +- #address-cells = <1>; > +- #size-cells = <0>; > +- reg : The MDIO bus offset within the MDIO range. I would just refer to Documentation/devicetree/bindings/net/phy.txt for the child node properties. Other than that: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On 2016-10-07 17:18, Pantelis Antoniou wrote: > From: Georgi Vlaev <gvlaev@juniper.net> > > Add device tree bindings document for the SAM MDIO block > present in Juniper's SAM FPGA. > > Signed-off-by: Georgi Vlaev <gvlaev@juniper.net> > [Ported from Juniper kernel] > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > --- > Documentation/devicetree/bindings/net/mdio-sam.txt | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/mdio-sam.txt > > diff --git a/Documentation/devicetree/bindings/net/mdio-sam.txt b/Documentation/devicetree/bindings/net/mdio-sam.txt > new file mode 100644 > index 0000000..7d354e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mdio-sam.txt > @@ -0,0 +1,48 @@ > +Juniper SAM FPGA MFD MDIO bus properties. > + > +Required properties: > +- compatible : "jnx,mdio-sam" > +- reg : The start offset of the MDIO bus range > +- #address-cells = <1>; > +- #size-cells = <0>; > + > +Optional properties: > + > +Required properties for child nodes: > +- #address-cells = <1>; > +- #size-cells = <0>; > +- reg : The MDIO bus offset within the MDIO range. > + > + > +Example : > + > + sam@10 { > + compatible = "jnx,sam"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mdio-sam@10 { This should be mdio-sam@40000, OR ... > + compatible = "jnx,mdio-sam"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x40000>; ... this should be reg = <0x10>. AFAIK. Cheers, Peter > + > + mdio0: mdio-sam@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0>; > + }; > + > + mdio1: mdio-sam@4000 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x4000>; > + }; > + > + mdio2: mdio-sam@8000 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x8000>; > + }; > + }; > + }; >
diff --git a/Documentation/devicetree/bindings/net/mdio-sam.txt b/Documentation/devicetree/bindings/net/mdio-sam.txt new file mode 100644 index 0000000..7d354e0 --- /dev/null +++ b/Documentation/devicetree/bindings/net/mdio-sam.txt @@ -0,0 +1,48 @@ +Juniper SAM FPGA MFD MDIO bus properties. + +Required properties: +- compatible : "jnx,mdio-sam" +- reg : The start offset of the MDIO bus range +- #address-cells = <1>; +- #size-cells = <0>; + +Optional properties: + +Required properties for child nodes: +- #address-cells = <1>; +- #size-cells = <0>; +- reg : The MDIO bus offset within the MDIO range. + + +Example : + + sam@10 { + compatible = "jnx,sam"; + #address-cells = <1>; + #size-cells = <0>; + + mdio-sam@10 { + compatible = "jnx,mdio-sam"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x40000>; + + mdio0: mdio-sam@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x0>; + }; + + mdio1: mdio-sam@4000 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x4000>; + }; + + mdio2: mdio-sam@8000 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x8000>; + }; + }; + };