diff mbox

acpcia: Makefile.am: include exconcat.c into libfwtsiasl build (LP: #1631354)

Message ID 20161007124438.1255-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Oct. 7, 2016, 12:44 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

We're missing the new exconcat in libfwtsiasl which means it is
picked up by fwts in libfwtsacpica instead, which ends up using
an uninitialized aliased AcpiGbl_OperandCache causing an
AE_NO_MEMORY while evaluating a constant string expression because
the cache was null. Fix this by adding in the missing source into
the iasl library.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpica/source/compiler/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Hung Oct. 12, 2016, 6:26 a.m. UTC | #1
On 2016-10-07 5:44 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We're missing the new exconcat in libfwtsiasl which means it is
> picked up by fwts in libfwtsacpica instead, which ends up using
> an uninitialized aliased AcpiGbl_OperandCache causing an
> AE_NO_MEMORY while evaluating a constant string expression because
> the cache was null. Fix this by adding in the missing source into
> the iasl library.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpica/source/compiler/Makefile.am | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/source/compiler/Makefile.am b/src/acpica/source/compiler/Makefile.am
> index 6746488..cdcc5e2 100644
> --- a/src/acpica/source/compiler/Makefile.am
> +++ b/src/acpica/source/compiler/Makefile.am
> @@ -185,6 +185,7 @@ libfwtsiasl_la_SOURCES = 			\
>   	../components/dispatcher/dswload2.c 	\
>   	../components/dispatcher/dsargs.c 	\
>   	../components/dispatcher/dscontrol.c 	\
> +	../components/executer/exconcat.c	\
>   	../components/executer/exconvrt.c 	\
>   	../components/executer/excreate.c 	\
>   	../components/executer/exdump.c 	\
Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Oct. 12, 2016, 7:21 a.m. UTC | #2
On 2016年10月07日 20:44, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> We're missing the new exconcat in libfwtsiasl which means it is
> picked up by fwts in libfwtsacpica instead, which ends up using
> an uninitialized aliased AcpiGbl_OperandCache causing an
> AE_NO_MEMORY while evaluating a constant string expression because
> the cache was null. Fix this by adding in the missing source into
> the iasl library.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/source/compiler/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/source/compiler/Makefile.am b/src/acpica/source/compiler/Makefile.am
> index 6746488..cdcc5e2 100644
> --- a/src/acpica/source/compiler/Makefile.am
> +++ b/src/acpica/source/compiler/Makefile.am
> @@ -185,6 +185,7 @@ libfwtsiasl_la_SOURCES = 			\
>  	../components/dispatcher/dswload2.c 	\
>  	../components/dispatcher/dsargs.c 	\
>  	../components/dispatcher/dscontrol.c 	\
> +	../components/executer/exconcat.c	\
>  	../components/executer/exconvrt.c 	\
>  	../components/executer/excreate.c 	\
>  	../components/executer/exdump.c 	\
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpica/source/compiler/Makefile.am b/src/acpica/source/compiler/Makefile.am
index 6746488..cdcc5e2 100644
--- a/src/acpica/source/compiler/Makefile.am
+++ b/src/acpica/source/compiler/Makefile.am
@@ -185,6 +185,7 @@  libfwtsiasl_la_SOURCES = 			\
 	../components/dispatcher/dswload2.c 	\
 	../components/dispatcher/dsargs.c 	\
 	../components/dispatcher/dscontrol.c 	\
+	../components/executer/exconcat.c	\
 	../components/executer/exconvrt.c 	\
 	../components/executer/excreate.c 	\
 	../components/executer/exdump.c 	\