| Message ID | 1475762253-16759-1-git-send-email-geert@linux-m68k.org |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Geert Uytterhoeven wrote: > config QCOM_EMAC > tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support" > + depends on HAS_DMA I think it needs to depend on HAS_IOMEM as well, to fix this error in arch/um: drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove': >> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] iounmap(adpt->phy.digital);
On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi <timur@codeaurora.org> wrote: > Geert Uytterhoeven wrote: >> >> config QCOM_EMAC >> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet >> support" >> + depends on HAS_DMA > > > I think it needs to depend on HAS_IOMEM as well, to fix this error in > arch/um: > > drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove': >>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit >>> declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(adpt->phy.digital); Probably, I don't do UML allmodconfig builds. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Geert Uytterhoeven wrote: > Probably, I don't do UML allmodconfig builds. > > Gr{oetje,eeting}s, Would you mind submitting another version of your patch that includes HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot?
On Thu, Oct 6, 2016 at 4:12 PM, Timur Tabi <timur@codeaurora.org> wrote: > Geert Uytterhoeven wrote: >> >> Probably, I don't do UML allmodconfig builds. >> >> Gr{oetje,eeting}s, > > > Would you mind submitting another version of your patch that includes > HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot? Done. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig index 9ba568db576fb0e6..fe94d2baeaf26aa6 100644 --- a/drivers/net/ethernet/qualcomm/Kconfig +++ b/drivers/net/ethernet/qualcomm/Kconfig @@ -26,6 +26,7 @@ config QCA7000 config QCOM_EMAC tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support" + depends on HAS_DMA select CRC32 select PHYLIB ---help---
If NO_DMA=y: drivers/built-in.o: In function `emac_probe': emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops' emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops' emac.c:(.text+0x378112): undefined reference to `bad_dma_ops' emac.c:(.text+0x378146): undefined reference to `bad_dma_ops' emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops' drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow Add a dependency on HAS_DMA to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/ethernet/qualcomm/Kconfig | 1 + 1 file changed, 1 insertion(+)