Patchwork Fix PR45570

login
register
mail settings
Submitter H.J. Lu
Date Oct. 14, 2010, 3:54 p.m.
Message ID <AANLkTinfCK1oyhM2QGkTmnqHHjqZFwkUOaezta515QRx@mail.gmail.com>
Download mbox | patch
Permalink /patch/67836/
State New
Headers show

Comments

H.J. Lu - Oct. 14, 2010, 3:54 p.m.
2010/10/5 Andrey Belevantsev <abel@ispras.ru>:
> Hello,
>
> As explained in the PR trail, this is the variant of PR40101 when we cannot
> devise a positive seqno for a bookkeeping copy by examining insn's
> neighbors.  Fixed by removing the assert and allowing the code of PR40101
> patch to provide an arbitrary positive value.
>
> Bootstrapped and regtested on ia64-linux, the testcase is also verified on
> x86-64 as reported in the PR.  Ok for trunk?
>
> Andrey
>
> 2010-10-05  Andrey Belevantsev  <abel@ispras.ru>
>
>        PR rtl-optimization/45570
>
>        * sel-sched-ir.c (cfg_preds_1): When walking out of the region,
> assert
>        that we are pipelining outer loops.  Allow returning zero
> predecessors.
>
>        * gcc.dg/pr45570.c: New test.
>
>

I checked in this patch to fix typos in testcase.
Andrey Belevantsev - Oct. 14, 2010, 3:59 p.m.
On 14.10.2010 19:54, H.J. Lu wrote:
> I checked in this patch to fix typos in testcase.
Thanks!  I thought this new file duplication is a svn bug which I've
already hit once; does it ring a bell to anybody?

Andrey
Andrew Pinski - Oct. 14, 2010, 4:32 p.m.
2010/10/14 Andrey Belevantsev <abel@ispras.ru>:
> On 14.10.2010 19:54, H.J. Lu wrote:
>>
>> I checked in this patch to fix typos in testcase.
>
> Thanks!  I thought this new file duplication is a svn bug which I've
> already hit once; does it ring a bell to anybody?

Not a svn bug but rather how "svn revert" works on newly added files.
It just removes the reference to adding the file and does not remove
the file itself.

Thanks,
Andrew Pinski

Patch

Index: gcc.dg/pr45570.c
===================================================================
--- gcc.dg/pr45570.c	(revision 165473)
+++ gcc.dg/pr45570.c	(working copy)
@@ -1,5 +1,5 @@ 
-/* { dg-do compile { target powerpc*-*-* ia64-*-* x86_64-*-* } } */
-/* { dg-options "O3 -fselective-scheduling2 -fsel-sched-pipelining
-fsel-sched-pipelining-outer-loops -ftracer" } */
+/* { dg-do compile { target powerpc*-*-* ia64-*-* i?86-*-* x86_64-*-* } } */
+/* { dg-options "-O3 -fselective-scheduling2 -fsel-sched-pipelining
-fsel-sched-pipelining-outer-loops -ftracer" } */
 void
 parser_get_next_char (char c, int qm, char *p)
 {
@@ -26,33 +26,3 @@  parser_get_next_parameter (char *p)
 {
   parser_get_next_char (':', 1, p);
 }
-
-/* { dg-do compile { target powerpc*-*-* ia64-*-* x86_64-*-* } } */
-/* { dg-options "O3 -fselective-scheduling2 -fsel-sched-pipelining
-fsel-sched-pipelining-outer-loops -ftracer" } */
-void
-parser_get_next_char (char c, int qm, char *p)
-{
-  int quote_mode = 0;
-  for (; *p; p++)
-    {
-      if (qm)
-	{
-	  if (quote_mode == 0 && *p == '"' && *(p - 1))
-	    {
-	      quote_mode = 1;
-	      continue;
-	    }
-	  if (quote_mode && *p == '"' && *(p - 1))
-	    quote_mode = 0;
-	}
-      if (quote_mode == 0 && *p == c && *(p - 1))
-	break;
-    }
-}
-
-void
-parser_get_next_parameter (char *p)
-{
-  parser_get_next_char (':', 1, p);
-}
-
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 165473)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@ 
+2010-10-14  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gcc.dg/pr45570.c: Fix typos.  Also run for i?86-*-*.
+
 2010-10-14  Joseph Myers  <joseph@codesourcery.com>

 	PR c/45969