From patchwork Thu Oct 14 13:30:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 67824 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6B0021007D5 for ; Fri, 15 Oct 2010 00:34:27 +1100 (EST) Received: from localhost ([127.0.0.1]:45416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6Nuu-0005W8-8N for incoming@patchwork.ozlabs.org; Thu, 14 Oct 2010 09:32:20 -0400 Received: from [140.186.70.92] (port=47900 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6Nty-0005M9-He for qemu-devel@nongnu.org; Thu, 14 Oct 2010 09:31:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6Nsz-0007wf-H2 for qemu-devel@nongnu.org; Thu, 14 Oct 2010 09:30:26 -0400 Received: from mtagate6.uk.ibm.com ([194.196.100.166]:35451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6Nsz-0007wM-9o for qemu-devel@nongnu.org; Thu, 14 Oct 2010 09:30:21 -0400 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9EDUKpv028776 for ; Thu, 14 Oct 2010 13:30:20 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o9EDUDY13903672 for ; Thu, 14 Oct 2010 14:30:21 +0100 Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o9EDUCDV009676 for ; Thu, 14 Oct 2010 14:30:12 +0100 Received: from stefan-thinkpad.manchester-maybrook.uk.ibm.com (dyn-9-174-219-27.manchester-maybrook.uk.ibm.com [9.174.219.27]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o9EDUCsv009666; Thu, 14 Oct 2010 14:30:12 +0100 From: Stefan Hajnoczi To: Date: Thu, 14 Oct 2010 14:30:05 +0100 Message-Id: <1287063006-7131-1-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: Kevin Wolf , Christoph Hellwig , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 1/2][qemu-iotests] add sub-cluster allocating write test for sparse image formats X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Image formats that grow the image file on demand and are organized into clusters must handle sub-cluster allocating writes. Such writes touch a portion of a previously unallocated data cluster. After the image file is grown with the written data, reads of that cluster should work as expected: 1. Sectors before the written region are zero. 2. The written region is present and the data is uncorrupted. 3. Sectors after the written region are zero. Signed-off-by: Stefan Hajnoczi --- 027 | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 027.out | 23 ++++++++++++++++++ group | 1 + 3 files changed, 101 insertions(+), 0 deletions(-) create mode 100755 027 create mode 100644 027.out diff --git a/027 b/027 new file mode 100755 index 0000000..67ecffc --- /dev/null +++ b/027 @@ -0,0 +1,77 @@ +#!/bin/bash +# +# Test that sub-cluster allocating writes zero the rest of the cluster +# +# Copyright (C) 2010 IBM, Corp. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +# creator +owner=stefanha@linux.vnet.ibm.com + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +_supported_fmt vmdk qcow qcow2 +_supported_os Linux + + +size=128M +cluster_size=65536 +subcluster_offset=1024 +subcluster_size=2048 +_make_test_img $size + +# This first write causes an L2 table to be allocated so that the next write +# doesn't need to allocate one and is therefore at the end of the image file. +# Otherwise an L2 table could get in the way after the data cluster. +echo +echo "== writing first cluster to populate metadata ==" +$QEMU_IO -c "write -pP 0xde $cluster_size $cluster_size" $TEST_IMG | _filter_qemu_io + +echo +echo "== writing at sub-cluster granularity ==" +$QEMU_IO -c "write -pP 0xa $subcluster_offset $subcluster_size" $TEST_IMG | _filter_qemu_io + +echo +echo "== verify pattern ==" +$QEMU_IO -c "read -pP 0xa $subcluster_offset $subcluster_size" $TEST_IMG | _filter_qemu_io + +echo +echo "== verify zeroes before sub-cluster pattern ==" +$QEMU_IO -c "read -pP 0 -l $subcluster_offset 0 $subcluster_size" $TEST_IMG | _filter_qemu_io + +echo +echo "== verify zeroes after sub-cluster pattern ==" +$QEMU_IO -c "read -pP 0 -l 512 -s $subcluster_size $subcluster_offset $(( subcluster_size + 512 ))" $TEST_IMG | _filter_qemu_io + +# success, all done +echo "*** done" +rm -f $seq.full +status=0 diff --git a/027.out b/027.out new file mode 100644 index 0000000..a45c303 --- /dev/null +++ b/027.out @@ -0,0 +1,23 @@ +QA output created by 027 +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 + +== writing first cluster to populate metadata == +wrote 65536/65536 bytes at offset 65536 +64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +== writing at sub-cluster granularity == +wrote 2048/2048 bytes at offset 1024 +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +== verify pattern == +read 2048/2048 bytes at offset 1024 +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +== verify zeroes before sub-cluster pattern == +read 2048/2048 bytes at offset 0 +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +== verify zeroes after sub-cluster pattern == +read 2560/2560 bytes at offset 1024 +2 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +*** done diff --git a/group b/group index 44581a9..4c8c419 100644 --- a/group +++ b/group @@ -33,3 +33,4 @@ 024 rw backing auto 025 rw auto 026 rw blkdbg auto +027 rw auto