| Submitter | Markus Armbruster |
|---|---|
| Date | Oct. 14, 2010, 9:19 a.m. |
| Message ID | <m31v7tgmif.fsf@blackfin.pond.sub.org> |
| Download | mbox | patch |
| Permalink | /patch/67804/ |
| State | New |
| Headers | show |
Comments
Thanks, applied. On Thu, Oct 14, 2010 at 9:19 AM, Markus Armbruster <armbru@redhat.com> wrote: > -Wall enables a bunch of warnings at once. configure puts it after > $gcc_flags. This makes it impossible to disable warnings enabled by > -Wall there. Fix by putting configured flags last. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > configure | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index d303061..3a12f92 100755 > --- a/configure > +++ b/configure > @@ -154,7 +155,7 @@ int main(void) { return 0; } > EOF > for flag in $gcc_flags; do > if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then > - QEMU_CFLAGS="$flag $QEMU_CFLAGS" > + QEMU_CFLAGS="$QEMU_CFLAGS $flag" > fi > done > > -- > 1.7.2.3 >
Patch
diff --git a/configure b/configure index d303061..3a12f92 100755 --- a/configure +++ b/configure @@ -154,7 +155,7 @@ int main(void) { return 0; } EOF for flag in $gcc_flags; do if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then - QEMU_CFLAGS="$flag $QEMU_CFLAGS" + QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done
-Wall enables a bunch of warnings at once. configure puts it after $gcc_flags. This makes it impossible to disable warnings enabled by -Wall there. Fix by putting configured flags last. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- configure | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)