| Message ID | c544792c391cd93b7b129f9cb647f2a5b89eb632.1475516567.git.alistair.francis@xilinx.com |
|---|---|
| State | New |
| Headers | show |
On 10/03/2016 03:18 PM, Alistair Francis wrote: > Add a list of known restrictions and future work that will fix these > restrictions. > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > --- > > docs/generic-loader.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt > index 8fcb550..305cbc8 100644 > --- a/docs/generic-loader.txt > +++ b/docs/generic-loader.txt > @@ -82,3 +82,10 @@ with a '0x'. > > An example of loading an ELF file which CPU0 will boot is shown below: > -device loader,file=./images/boot.elf,cpu-num=0 > + > +Restrictions and ToDos > +--------------------- Might be worth it to have the --- line up with the text above. > + - At the moment it is just assumed that if you specify a cpu-num then you > + want to set the PC as well. This might not always be the case. In future > + the internal state 'set_pc' (which exists in the generic loader now) should > + be exposed to the user so that they can choose if the PC is set or not. >
On Mon, Oct 3, 2016 at 1:35 PM, Eric Blake <eblake@redhat.com> wrote: > On 10/03/2016 03:18 PM, Alistair Francis wrote: >> Add a list of known restrictions and future work that will fix these >> restrictions. >> >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> >> --- >> >> docs/generic-loader.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt >> index 8fcb550..305cbc8 100644 >> --- a/docs/generic-loader.txt >> +++ b/docs/generic-loader.txt >> @@ -82,3 +82,10 @@ with a '0x'. >> >> An example of loading an ELF file which CPU0 will boot is shown below: >> -device loader,file=./images/boot.elf,cpu-num=0 >> + >> +Restrictions and ToDos >> +--------------------- > > Might be worth it to have the --- line up with the text above. It's the same length as all the other --- lines. Should I increase them all to the same length as the title? Thanks, Alistair > >> + - At the moment it is just assumed that if you specify a cpu-num then you >> + want to set the PC as well. This might not always be the case. In future >> + the internal state 'set_pc' (which exists in the generic loader now) should >> + be exposed to the user so that they can choose if the PC is set or not. >> > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
On 10/03/2016 03:42 PM, Alistair Francis wrote: >>> An example of loading an ELF file which CPU0 will boot is shown below: >>> -device loader,file=./images/boot.elf,cpu-num=0 >>> + >>> +Restrictions and ToDos >>> +--------------------- >> >> Might be worth it to have the --- line up with the text above. > > It's the same length as all the other --- lines. Should I increase > them all to the same length as the title? It's only cosmetic, but yes, a lot of files under docs/ use variable-length separators that act as an underline to the text above, rather than fixed-length separators that have no relation to the text they are emphasizing.
On Mon, Oct 3, 2016 at 1:45 PM, Eric Blake <eblake@redhat.com> wrote: > On 10/03/2016 03:42 PM, Alistair Francis wrote: > >>>> An example of loading an ELF file which CPU0 will boot is shown below: >>>> -device loader,file=./images/boot.elf,cpu-num=0 >>>> + >>>> +Restrictions and ToDos >>>> +--------------------- >>> >>> Might be worth it to have the --- line up with the text above. >> >> It's the same length as all the other --- lines. Should I increase >> them all to the same length as the title? > > It's only cosmetic, but yes, a lot of files under docs/ use > variable-length separators that act as an underline to the text above, > rather than fixed-length separators that have no relation to the text > they are emphasizing. Ok, I have sent a V2 that fixes the line length. Thanks, Alistair > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt index 8fcb550..305cbc8 100644 --- a/docs/generic-loader.txt +++ b/docs/generic-loader.txt @@ -82,3 +82,10 @@ with a '0x'. An example of loading an ELF file which CPU0 will boot is shown below: -device loader,file=./images/boot.elf,cpu-num=0 + +Restrictions and ToDos +--------------------- + - At the moment it is just assumed that if you specify a cpu-num then you + want to set the PC as well. This might not always be the case. In future + the internal state 'set_pc' (which exists in the generic loader now) should + be exposed to the user so that they can choose if the PC is set or not.
Add a list of known restrictions and future work that will fix these restrictions. Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- docs/generic-loader.txt | 7 +++++++ 1 file changed, 7 insertions(+)