[ovs-dev] Fix missing system-id in INSTALL.Docker
diff mbox

Message ID CAM_3v9+9xNOgF4qz-s=t1L8EznwqxriRpPq_T3vz_+A2-M5Dpg@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Guru Shetty Oct. 3, 2016, 7:56 p.m. UTC
On 3 October 2016 at 12:30, Hui Kang <hkang.sunysb@gmail.com> wrote:

> Signed-off-by: Hui Kang <kangh@us.ibm.com>
>
Can you please use the same Author and Signed-off-by information. Right now
you are:

Author: Hui Kang <hkang.sunysb@gmail.com>
Signed-off-by: Hui Kang <kangh@us.ibm.com>



> ---
>  INSTALL.Docker.md | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
> index b62922d..5cb49d0 100644
> --- a/INSTALL.Docker.md
> +++ b/INSTALL.Docker.md
> @@ -69,6 +69,8 @@ gets cleared.  It is harmless to run it again in any
> case.)
>  $LOCAL_IP in the below command is the IP address via which other hosts
>  can reach this host.  This acts as your local tunnel endpoint.
>
> +$SYSTEM_ID in the below command is the unique identifier for the docker
> host.
>

I understand where you are coming from, but SYSTEM_ID is always populated
if you use startup scripts to start OVS. So in that case, we are
effectively overwriting it. How about something like this instead? (If you
are happy with it, please consider resubmitting your patch with something
like that.  If you prefer that I go ahead and do that, let me know.)



> +
>  $ENCAP_TYPE is the type of tunnel that you would like to use for overlay
>  networking.  The options are "geneve" or "stt".  (Please note that your
>  kernel should have support for your chosen $ENCAP_TYPE.  Both geneve
> @@ -79,8 +81,10 @@ support in upstream Linux.  You can verify whether you
> have the support in your
>  kernel by doing a "lsmod | grep $ENCAP_TYPE".)
>
>  ```
> -ovs-vsctl set Open_vSwitch . external_ids:ovn-remote="tcp:$CENTRAL_IP:6642"
> \
> -  external_ids:ovn-nb="tcp:$CENTRAL_IP:6641" external_ids:ovn-encap-ip=$LOCAL_IP
> external_ids:ovn-encap-type="$ENCAP_TYPE"
> +ovs-vsctl set Open_vSwitch . external-ids:system-id=$SYSTEM_ID \
> +  external_ids:ovn-remote="tcp:$CENTRAL_IP:6642" \
> +  external_ids:ovn-nb="tcp:$CENTRAL_IP:6641" \
> +  external_ids:ovn-encap-ip=$LOCAL_IP external_ids:ovn-encap-type="$
> ENCAP_TYPE"
>  ```
>
>  And finally, start the ovn-controller.  (You need to run the below command
> --
> 1.9.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>

Patch
diff mbox

diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
index b62922d..007ad7e 100644
--- a/INSTALL.Docker.md
+++ b/INSTALL.Docker.md
@@ -83,6 +83,14 @@  ovs-vsctl set Open_vSwitch .
external_ids:ovn-remote="tcp:$CE
   external_ids:ovn-nb="tcp:$CENTRAL_IP:6641"
external_ids:ovn-encap-ip=$LOCAL_I
 ```

+If you started Open vSwitch manually (without the assistance of system
+startup scripts provided by packages like .deb or .rpm), you should
provide a
+unique identification, $SYSTEM_ID for this host.
+
+```
+ovs-vsctl set Open_vSwitch . external_ids:system-id=$SYSTEM_ID
+```
+