diff mbox

Add TCP_REPAIR_WINDOW from Linux 4.8

Message ID alpine.DEB.2.20.1610031746250.17903@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Oct. 3, 2016, 5:46 p.m. UTC 
Linux 4.8 adds TCP_REPAIR_WINDOW to include/uapi/linux/tcp.h.  This
patch adds it to sysdeps/gnu/netinet/tcp.h accordingly.

Tested for x86_64 and x86 (testsuite, and that installed shared
libraries are unchanged by the patch).

2016-10-03  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/gnu/netinet/tcp.h (TCP_REPAIR_WINDOW): New macro.

Comments

Florian Weimer Oct. 3, 2016, 5:49 p.m. UTC | #1 
* Joseph Myers:

> Linux 4.8 adds TCP_REPAIR_WINDOW to include/uapi/linux/tcp.h.  This
> patch adds it to sysdeps/gnu/netinet/tcp.h accordingly.
>
> Tested for x86_64 and x86 (testsuite, and that installed shared
> libraries are unchanged by the patch).

Please also add struct tcp_repair_window, otherwise the #define
doesn't make much sense.  Thanks.
Carlos O'Donell Oct. 3, 2016, 8:40 p.m. UTC | #2 
On 10/03/2016 01:49 PM, Florian Weimer wrote:
> * Joseph Myers:
> 
>> Linux 4.8 adds TCP_REPAIR_WINDOW to include/uapi/linux/tcp.h.  This
>> patch adds it to sysdeps/gnu/netinet/tcp.h accordingly.
>>
>> Tested for x86_64 and x86 (testsuite, and that installed shared
>> libraries are unchanged by the patch).
> 
> Please also add struct tcp_repair_window, otherwise the #define
> doesn't make much sense.  Thanks.
> 

And double check it doesn't need coordination if you might ever want
to include the UAPI header and the glibc header.
Joseph Myers Oct. 3, 2016, 8:58 p.m. UTC | #3 
On Mon, 3 Oct 2016, Carlos O'Donell wrote:

> And double check it doesn't need coordination if you might ever want
> to include the UAPI header and the glibc header.

Since both headers already have many of the same structures without any 
conditionals on them, I don't think adding a new structure indicates doing 
anything new regarding coordination.
Florian Weimer Oct. 3, 2016, 9 p.m. UTC | #4 
* Joseph Myers:

> On Mon, 3 Oct 2016, Carlos O'Donell wrote:
>
>> And double check it doesn't need coordination if you might ever want
>> to include the UAPI header and the glibc header.
>
> Since both headers already have many of the same structures without any 
> conditionals on them, I don't think adding a new structure indicates doing 
> anything new regarding coordination.

Agreed.
diff mbox

Patch

diff --git a/sysdeps/gnu/netinet/tcp.h b/sysdeps/gnu/netinet/tcp.h
index 3fbea54..a00b425 100644
--- a/sysdeps/gnu/netinet/tcp.h
+++ b/sysdeps/gnu/netinet/tcp.h
@@ -69,6 +69,7 @@ 
 				       connections.  */
 #define TCP_SAVED_SYN		 28 /* Get SYN headers recorded for
 				       connection.  */
+#define TCP_REPAIR_WINDOW	 29 /* Get/set window parameters.  */
 
 #ifdef __USE_MISC
 # include <sys/types.h>