diff mbox

[v2,2/4] tests/docker: test-build script

Message ID 20161003163212.8101-3-alex.bennee@linaro.org
State New
Headers show

Commit Message

Alex Bennée Oct. 3, 2016, 4:32 p.m. UTC
Much like test-quick but only builds. This is useful for some of the
build targets like ThreadSanitizer that don't yet pass "make check".

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/test-build | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100755 tests/docker/test-build

Comments

Fam Zheng Oct. 11, 2016, 8:31 a.m. UTC | #1
On Mon, 10/03 17:32, Alex Bennée wrote:
> Much like test-quick but only builds. This is useful for some of the
> build targets like ThreadSanitizer that don't yet pass "make check".
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/test-build | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100755 tests/docker/test-build
> 
> diff --git a/tests/docker/test-build b/tests/docker/test-build
> new file mode 100755
> index 0000000..d237ead
> --- /dev/null
> +++ b/tests/docker/test-build
> @@ -0,0 +1,18 @@
> +#!/bin/bash -e
> +#
> +# Quick compiling test that everyone already does. But why not automate it?
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +. common.rc
> +
> +DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"

Like I said in v1, better flatten this to "x86_64-softmmu,aarch64-softmmu" as it
is in test-quick now.

Fam

> +TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
> +build_qemu
> -- 
> 2.9.3
>
Alex Bennée Oct. 11, 2016, 8:49 a.m. UTC | #2
Fam Zheng <famz@redhat.com> writes:

> On Mon, 10/03 17:32, Alex Bennée wrote:
>> Much like test-quick but only builds. This is useful for some of the
>> build targets like ThreadSanitizer that don't yet pass "make check".
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  tests/docker/test-build | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>  create mode 100755 tests/docker/test-build
>>
>> diff --git a/tests/docker/test-build b/tests/docker/test-build
>> new file mode 100755
>> index 0000000..d237ead
>> --- /dev/null
>> +++ b/tests/docker/test-build
>> @@ -0,0 +1,18 @@
>> +#!/bin/bash -e
>> +#
>> +# Quick compiling test that everyone already does. But why not automate it?
>> +#
>> +# Copyright (c) 2016 Red Hat Inc.
>> +#
>> +# Authors:
>> +#  Fam Zheng <famz@redhat.com>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2
>> +# or (at your option) any later version. See the COPYING file in
>> +# the top-level directory.
>> +
>> +. common.rc
>> +
>> +DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
>
> Like I said in v1, better flatten this to "x86_64-softmmu,aarch64-softmmu" as it
> is in test-quick now.

oops, sorry missed that. Will fix.

>
> Fam
>
>> +TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
>> +build_qemu
>> --
>> 2.9.3
>>


--
Alex Bennée
Fam Zheng Oct. 11, 2016, 9:55 a.m. UTC | #3
On Tue, 10/11 09:49, Alex Bennée wrote:
> 
> Fam Zheng <famz@redhat.com> writes:
> 
> > On Mon, 10/03 17:32, Alex Bennée wrote:
> >> Much like test-quick but only builds. This is useful for some of the
> >> build targets like ThreadSanitizer that don't yet pass "make check".
> >>
> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> ---
> >>  tests/docker/test-build | 18 ++++++++++++++++++
> >>  1 file changed, 18 insertions(+)
> >>  create mode 100755 tests/docker/test-build
> >>
> >> diff --git a/tests/docker/test-build b/tests/docker/test-build
> >> new file mode 100755
> >> index 0000000..d237ead
> >> --- /dev/null
> >> +++ b/tests/docker/test-build
> >> @@ -0,0 +1,18 @@
> >> +#!/bin/bash -e
> >> +#
> >> +# Quick compiling test that everyone already does. But why not automate it?
> >> +#
> >> +# Copyright (c) 2016 Red Hat Inc.
> >> +#
> >> +# Authors:
> >> +#  Fam Zheng <famz@redhat.com>
> >> +#
> >> +# This work is licensed under the terms of the GNU GPL, version 2
> >> +# or (at your option) any later version. See the COPYING file in
> >> +# the top-level directory.
> >> +
> >> +. common.rc
> >> +
> >> +DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
> >
> > Like I said in v1, better flatten this to "x86_64-softmmu,aarch64-softmmu" as it
> > is in test-quick now.
> 
> oops, sorry missed that. Will fix.

While we are at it, how about copying from test-full to cover more targets?

Fam

> 
> >
> > Fam
> >
> >> +TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
> >> +build_qemu
> >> --
> >> 2.9.3
> >>
> 
> 
> --
> Alex Bennée
diff mbox

Patch

diff --git a/tests/docker/test-build b/tests/docker/test-build
new file mode 100755
index 0000000..d237ead
--- /dev/null
+++ b/tests/docker/test-build
@@ -0,0 +1,18 @@ 
+#!/bin/bash -e
+#
+# Quick compiling test that everyone already does. But why not automate it?
+#
+# Copyright (c) 2016 Red Hat Inc.
+#
+# Authors:
+#  Fam Zheng <famz@redhat.com>
+#
+# This work is licensed under the terms of the GNU GPL, version 2
+# or (at your option) any later version. See the COPYING file in
+# the top-level directory.
+
+. common.rc
+
+DEF_TARGET_LIST="$(echo {x86_64,aarch64}-softmmu)"
+TARGET_LIST=${TARGET_LIST:-$DEF_TARGET_LIST} \
+build_qemu