| Message ID | 1475391856-15046-1-git-send-email-christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Oct 02, 2016 at 09:04:16AM +0200, Christophe JAILLET wrote: > A call to 'ida_simple_remove()' is missing in the error handling path. > > This as been spotted with the following coccinelle script which tries to > detect missing 'ida_simple_remove()' call in error handling paths. Acked-by: Richard Cochran <richardcochran@gmail.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Date: Sun, 2 Oct 2016 09:04:16 +0200 > A call to 'ida_simple_remove()' is missing in the error handling path. > > This as been spotted with the following coccinelle script which tries to > detect missing 'ida_simple_remove()' call in error handling paths. ... > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied.
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index 2e481b9e8ea5..86280b7e41f3 100644 --- a/drivers/ptp/ptp_clock.c +++ b/drivers/ptp/ptp_clock.c @@ -263,6 +263,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info, no_device: mutex_destroy(&ptp->tsevq_mux); mutex_destroy(&ptp->pincfg_mux); + ida_simple_remove(&ptp_clocks_map, index); no_slot: kfree(ptp); no_memory:
A call to 'ida_simple_remove()' is missing in the error handling path. This as been spotted with the following coccinelle script which tries to detect missing 'ida_simple_remove()' call in error handling paths. /////////////// @@ expression x; identifier l; @@ * x = ida_simple_get(...); ... if (...) { ... } ... if (...) { ... goto l; } ... * l: ... when != ida_simple_remove(...); Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile-tested only --- drivers/ptp/ptp_clock.c | 1 + 1 file changed, 1 insertion(+)