diff mbox

[U-Boot,02/27] arc: Use asm-generic/io.h

Message ID 20161001141931.32354-3-paul.burton@imgtec.com
State Deferred
Delegated to: Tom Rini
Headers show

Commit Message

Paul Burton Oct. 1, 2016, 2:19 p.m. UTC 
Convert the arc architecture to make use of the new asm-generic/io.h to
provide address mapping functions. As the generic implementations are
suitable for arc this is primarily a matter of removing code.

Feedback from architecture maintainers is welcome.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: Alexey Brodkin <alexey.brodkin@synopsys.com>
---

 arch/arc/include/asm/io.h | 29 +----------------------------
 1 file changed, 1 insertion(+), 28 deletions(-)

Comments

Alexey Brodkin Oct. 3, 2016, 9:13 a.m. UTC | #1 
Hi Paul,

On Sat, 2016-10-01 at 15:19 +0100, Paul Burton wrote:
> Convert the arc architecture to make use of the new asm-generic/io.h to
> provide address mapping functions. As the generic implementations are
> suitable for arc this is primarily a matter of removing code.
> 
> Feedback from architecture maintainers is welcome.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Alexey Brodkin <alexey.brodkin@synopsys.com>
> ---

This is a very welcome patch really!
I've been thinking about it since the submission of ARC port
but was so lazy to do all that hard work.

So thanks for doing that and

Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
diff mbox

Patch

diff --git a/arch/arc/include/asm/io.h b/arch/arc/include/asm/io.h
index 42e7f22..a12303b 100644
--- a/arch/arc/include/asm/io.h
+++ b/arch/arc/include/asm/io.h
@@ -50,30 +50,6 @@ 
 #define __iowmb()		do { } while (0)
 #endif
 
-/*
- * Given a physical address and a length, return a virtual address
- * that can be used to access the memory range with the caching
- * properties specified by "flags".
- */
-#define MAP_NOCACHE	(0)
-#define MAP_WRCOMBINE	(0)
-#define MAP_WRBACK	(0)
-#define MAP_WRTHROUGH	(0)
-
-static inline void *
-map_physmem(phys_addr_t paddr, unsigned long len, unsigned long flags)
-{
-	return (void *)((unsigned long)paddr);
-}
-
-/*
- * Take down a mapping set up by map_physmem().
- */
-static inline void unmap_physmem(void *vaddr, unsigned long flags)
-{
-
-}
-
 static inline void sync(void)
 {
 	/* Not yet implemented */
@@ -302,9 +278,6 @@  static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
 #define setbits_8(addr, set) setbits(8, addr, set)
 #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
 
-static inline phys_addr_t virt_to_phys(void *vaddr)
-{
-	return (phys_addr_t)((unsigned long)vaddr);
-}
+#include <asm-generic/io.h>
 
 #endif	/* __ASM_ARC_IO_H */