Patchwork gianfar: fix double lock typo

login
register
mail settings
Submitter Dan Carpenter
Date Oct. 13, 2010, 7:19 p.m.
Message ID <20101013191954.GE6060@bicker>
Download mbox | patch
Permalink /patch/67727/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - Oct. 13, 2010, 7:19 p.m.
This should be a _restore() instead of a _save().

Signed-off-by: Dan Carpenter <error27@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 18, 2010, 8:55 a.m.
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 13 Oct 2010 21:19:55 +0200

> This should be a _restore() instead of a _save().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Good find, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index ae8e5d3..5c566eb 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -538,7 +538,7 @@  static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
 
 		unlock_tx_qs(priv);
 		unlock_rx_qs(priv);
-		local_irq_save(flags);
+		local_irq_restore(flags);
 
 		for (i = 0; i < priv->num_rx_queues; i++)
 			gfar_clean_rx_ring(priv->rx_queue[i],