[21/22] specs/qcow2: fix bitmap granularity qemu-specific note
diff mbox

Message ID 1475232808-4852-22-git-send-email-vsementsov@virtuozzo.com
State New
Headers show

Commit Message

Vladimir Sementsov-Ogievskiy Sept. 30, 2016, 10:53 a.m. UTC
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 docs/specs/qcow2.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Eric Blake Oct. 7, 2016, 8:18 p.m. UTC | #1
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  docs/specs/qcow2.txt | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
> index 80cdfd0..d3e292f 100644
> --- a/docs/specs/qcow2.txt
> +++ b/docs/specs/qcow2.txt
> @@ -472,8 +472,7 @@ Structure of a bitmap directory entry:
>               17:    granularity_bits
>                      Granularity bits. Valid values: 0 - 63.

Can we really theoretically go as low as 0, or are we constrained by the
fact that cluster_bits must be at least 9?

>  
> -                    Note: Qemu currently doesn't support granularity_bits
> -                    greater than 31.
> +                    Note: Qemu currently support only values 9 - 31.

s/support/supports/

>  
>                      Granularity is calculated as
>                          granularity = 1 << granularity_bits
>
Vladimir Sementsov-Ogievskiy Nov. 9, 2016, 4:43 p.m. UTC | #2
07.10.2016 23:18, Eric Blake wrote:
> On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   docs/specs/qcow2.txt | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
>> index 80cdfd0..d3e292f 100644
>> --- a/docs/specs/qcow2.txt
>> +++ b/docs/specs/qcow2.txt
>> @@ -472,8 +472,7 @@ Structure of a bitmap directory entry:
>>                17:    granularity_bits
>>                       Granularity bits. Valid values: 0 - 63.
> Can we really theoretically go as low as 0, or are we constrained by the
> fact that cluster_bits must be at least 9?

Bitmaps in qcow2 are abstract, they are not necessary related to 
BdrvDirtyBitmaps.. We do not know how the will be used in future, so 
there no reasons for hard restriction. However values near zero seems 
not very useful. I do not think we should change this. Note about Qemu 
is enough.


>
>>   
>> -                    Note: Qemu currently doesn't support granularity_bits
>> -                    greater than 31.
>> +                    Note: Qemu currently support only values 9 - 31.
> s/support/supports/
>
>>   
>>                       Granularity is calculated as
>>                           granularity = 1 << granularity_bits
>>

Patch
diff mbox

diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 80cdfd0..d3e292f 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -472,8 +472,7 @@  Structure of a bitmap directory entry:
              17:    granularity_bits
                     Granularity bits. Valid values: 0 - 63.
 
-                    Note: Qemu currently doesn't support granularity_bits
-                    greater than 31.
+                    Note: Qemu currently support only values 9 - 31.
 
                     Granularity is calculated as
                         granularity = 1 << granularity_bits