Patchwork [testsuite] Fix cmpsf-1.c

login
register
mail settings
Submitter Maxim Kuvyrkov
Date Oct. 12, 2010, 6:50 p.m.
Message ID <4CB4ADF9.5030103@codesourcery.com>
Download mbox | patch
Permalink /patch/67606/
State New
Headers show

Comments

Maxim Kuvyrkov - Oct. 12, 2010, 6:50 p.m.
The expected result matrix for cmpsf-1.c does not look correct.  It has
10 * (133 - 68) = 650
entries, but there are only
(8 * 8) * 6 = 384
tests.  Moreover, the result for 8'th test (0.0 < 1.0) is wrong; this 
causes the test to fail.

I suspect that the test was reduced, but the matrix was not updated.

The following patch lists the results generated with x86_64-linux 
mainline.  Does it look correct?

Thanks,
H.J. Lu - Oct. 12, 2010, 6:54 p.m.
On Tue, Oct 12, 2010 at 11:50 AM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
> The expected result matrix for cmpsf-1.c does not look correct.  It has
> 10 * (133 - 68) = 650
> entries, but there are only
> (8 * 8) * 6 = 384
> tests.  Moreover, the result for 8'th test (0.0 < 1.0) is wrong; this causes
> the test to fail.
>
> I suspect that the test was reduced, but the matrix was not updated.
>
> The following patch lists the results generated with x86_64-linux mainline.
>  Does it look correct?

This is

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45856

Can you try patch at

http://gcc.gnu.org/bugzilla/attachment.cgi?id=21994
Maxim Kuvyrkov - Oct. 12, 2010, 6:59 p.m.
On 10/12/10 10:54 PM, H.J. Lu wrote:
> On Tue, Oct 12, 2010 at 11:50 AM, Maxim Kuvyrkov<maxim@codesourcery.com>  wrote:
>> The expected result matrix for cmpsf-1.c does not look correct.  It has
>> 10 * (133 - 68) = 650
>> entries, but there are only
>> (8 * 8) * 6 = 384
>> tests.  Moreover, the result for 8'th test (0.0<  1.0) is wrong; this causes
>> the test to fail.
>>
>> I suspect that the test was reduced, but the matrix was not updated.
>>
>> The following patch lists the results generated with x86_64-linux mainline.
>>   Does it look correct?
>
> This is
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45856
>
> Can you try patch at
>
> http://gcc.gnu.org/bugzilla/attachment.cgi?id=21994

Yeap, this works.  I think it can be committed as obvious.

Thanks,
Michael Eager - Oct. 12, 2010, 10:49 p.m.
Maxim Kuvyrkov wrote:
> On 10/12/10 10:54 PM, H.J. Lu wrote:
>> On Tue, Oct 12, 2010 at 11:50 AM, Maxim 
>> Kuvyrkov<maxim@codesourcery.com>  wrote:
>>> The expected result matrix for cmpsf-1.c does not look correct.  It has
>>> 10 * (133 - 68) = 650
>>> entries, but there are only
>>> (8 * 8) * 6 = 384
>>> tests.  Moreover, the result for 8'th test (0.0<  1.0) is wrong; this 
>>> causes
>>> the test to fail.
>>>
>>> I suspect that the test was reduced, but the matrix was not updated.
>>>
>>> The following patch lists the results generated with x86_64-linux 
>>> mainline.
>>>   Does it look correct?
>>
>> This is
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45856
>>
>> Can you try patch at
>>
>> http://gcc.gnu.org/bugzilla/attachment.cgi?id=21994
> 
> Yeap, this works.  I think it can be committed as obvious.

Patches committed.
Michael Eager - Oct. 13, 2010, 2:30 a.m.
Michael Eager wrote:
> Maxim Kuvyrkov wrote:
>> On 10/12/10 10:54 PM, H.J. Lu wrote:
>>> On Tue, Oct 12, 2010 at 11:50 AM, Maxim 
>>> Kuvyrkov<maxim@codesourcery.com>  wrote:
>>>> The expected result matrix for cmpsf-1.c does not look correct.  It has
>>>> 10 * (133 - 68) = 650
>>>> entries, but there are only
>>>> (8 * 8) * 6 = 384
>>>> tests.  Moreover, the result for 8'th test (0.0<  1.0) is wrong; 
>>>> this causes
>>>> the test to fail.
>>>>
>>>> I suspect that the test was reduced, but the matrix was not updated.
>>>>
>>>> The following patch lists the results generated with x86_64-linux 
>>>> mainline.
>>>>   Does it look correct?
>>>
>>> This is
>>>
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45856
>>>
>>> Can you try patch at
>>>
>>> http://gcc.gnu.org/bugzilla/attachment.cgi?id=21994
>>
>> Yeap, this works.  I think it can be committed as obvious.
> 
> Patches committed.

Revision 165410

Patch

Index: gcc/testsuite/gcc.c-torture/execute/cmpsf-1.c
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/cmpsf-1.c	(revision 302295)
+++ gcc/testsuite/gcc.c-torture/execute/cmpsf-1.c	(working copy)
@@ -65,70 +65,70 @@  float args[] =
 
 int correct_results[] =
 {
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, F, T, T, F,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, T, F, F, T,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  T, F, F, T, F, T, F, T, F, T,
-  F, T, F, T, T, F, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, T, F, F, T, T, F, F, T,
-  F, T, T, F, F, T, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, F, T, T, F, F, T, T, F,
-  F, T, T, F, F, T, F, T, T, F,
-  T, F, F, T, F, T, F, T, F, T
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  T, F, F, T, F, T,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  T, F, F, T, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  F, T, F, T, T, F,
+  T, F, F, T, F, T,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, F, T, T, F,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  F, T, T, F, F, T,
+  T, F, F, T, F, T
 };
 
 int