| Message ID | 1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
Am 28.09.2016 um 07:30 hat Wang WeiWei geschrieben: > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com> > Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > Reviewed-by: Eric Blake <eblake@redhat.com> > --- > qapi/block-core.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ada3202..0935b81 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2184,7 +2184,7 @@ > # @mode: the replication mode > # > # @top-id: #optional In secondary mode, node name or device ID of the root > -# node who owns the replication node chain. Ignored in primary mode. > +# node who owns the replication node chain. Must not be given in primary mode. > # > # Since: 2.8 > ## The matching code in block/replication.c is missing to actually error out if the option is given in primary mode. Kevin
On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: Please send a proper commit message and commit description. "modify top-id's comments" says almost nothing and there is no commit description. I don't know why you are making this change so I can't review and apply it. > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com> > Signed-off-by: Wang WeiWei <wangww.fnst@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com> > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > Reviewed-by: Eric Blake <eblake@redhat.com> > --- > qapi/block-core.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index ada3202..0935b81 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2184,7 +2184,7 @@ > # @mode: the replication mode > # > # @top-id: #optional In secondary mode, node name or device ID of the root > -# node who owns the replication node chain. Ignored in primary mode. > +# node who owns the replication node chain. Must not be given in primary mode. > # > # Since: 2.8 > ## > -- > 1.9.3 > > > >
On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: > > Please send a proper commit message and commit description. "modify > top-id's comments" says almost nothing and there is no commit > description. I don't know why you are making this change so I can't > review and apply it. > >> +++ b/qapi/block-core.json >> @@ -2184,7 +2184,7 @@ >> # @mode: the replication mode >> # >> # @top-id: #optional In secondary mode, node name or device ID of the root >> -# node who owns the replication node chain. Ignored in primary mode. >> +# node who owns the replication node chain. Must not be given in primary mode. That, and your line exceeds 80 columns; please wrap it.
Ok, I'wll wrap it. On 09/29/2016 09:35 PM, Eric Blake wrote: > On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: >> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: >> >> Please send a proper commit message and commit description. "modify >> top-id's comments" says almost nothing and there is no commit >> description. I don't know why you are making this change so I can't >> review and apply it. >> > >>> +++ b/qapi/block-core.json >>> @@ -2184,7 +2184,7 @@ >>> # @mode: the replication mode >>> # >>> # @top-id: #optional In secondary mode, node name or device ID of the root >>> -# node who owns the replication node chain. Ignored in primary mode. >>> +# node who owns the replication node chain. Must not be given in primary mode. > > That, and your line exceeds 80 columns; please wrap it. >
diff --git a/qapi/block-core.json b/qapi/block-core.json index ada3202..0935b81 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2184,7 +2184,7 @@ # @mode: the replication mode # # @top-id: #optional In secondary mode, node name or device ID of the root -# node who owns the replication node chain. Ignored in primary mode. +# node who owns the replication node chain. Must not be given in primary mode. # # Since: 2.8 ##