diff mbox

[v3,1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding

Message ID 1474928832-8766-2-git-send-email-peda@axentia.se
State Changes Requested, archived
Headers show

Commit Message

Peter Rosin Sept. 26, 2016, 10:27 p.m. UTC 
The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt

Comments

Rob Herring (Arm) Oct. 3, 2016, 6:46 p.m. UTC | #1 
On Tue, Sep 27, 2016 at 12:27:11AM +0200, Peter Rosin wrote:
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> new file mode 100644
> index 000000000000..715ff7e332f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> @@ -0,0 +1,36 @@
> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "sharp,lq150x1lg11"
> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)

Should be named according to the input, so vcc-supply.

> +
> +Optional properties:
> +- backlight: phandle of the backlight device
> +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
> +- lvds-gpios: a single GPIO for the SELLVDS pin.

Why not sellvds-gpios?

> +
> +If lrud-gpios and/or ldvs-gpios are not specified, the RL/UD and/or SELLVDS

typos...

> +pins are assumed to be handled appropriately by the hardware.
> +
> +Example:
> +
> +	backlight: backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm 0 100000>;                      /* VBR */
> +
> +		brightness-levels = <0 20 40 60 80 100>;
> +		default-brightness-level = <2>;
> +
> +		power-supply = <&vdd_12v_reg>;               /* VDD */
> +		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
> +	};
> +
> +	panel {
> +		compatible = "sharp,lq150x1lg11";
> +
> +		power-supply = <&vcc_3v3_reg>;               /* VCC */
> +
> +		backlight = <&backlight>;
> +		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
> +		lvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;    /* SELLVDS */
> +	};
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter Rosin Oct. 4, 2016, 4:58 a.m. UTC | #2 
On 2016-10-03 20:46, Rob Herring wrote:
> On Tue, Sep 27, 2016 at 12:27:11AM +0200, Peter Rosin wrote:
>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>>  1 file changed, 36 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>> new file mode 100644
>> index 000000000000..715ff7e332f2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>> @@ -0,0 +1,36 @@
>> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
>> +
>> +Required properties:
>> +- compatible: should be "sharp,lq150x1lg11"
>> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
> 
> Should be named according to the input, so vcc-supply.

Right, I wanted to do that, but the simple-panel bindings has power-supply
as required and I desperately wanted to be compatible in order to make use
of the simple-panel driver. That driver does require this entry, so I do
not see any way around it. Any advice for this situation?

>> +
>> +Optional properties:
>> +- backlight: phandle of the backlight device
>> +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
>> +- lvds-gpios: a single GPIO for the SELLVDS pin.
> 
> Why not sellvds-gpios?

I'll change that in v4.
 
>> +
>> +If lrud-gpios and/or ldvs-gpios are not specified, the RL/UD and/or SELLVDS
> 
> typos...

Good thing you added the plural, I found s/lrud/rlud/ and s/ldvs/lvds/
Nice catch btw, thanks!

>> +pins are assumed to be handled appropriately by the hardware.
>> +
>> +Example:
>> +
>> +	backlight: backlight {
>> +		compatible = "pwm-backlight";
>> +		pwms = <&pwm 0 100000>;                      /* VBR */
>> +
>> +		brightness-levels = <0 20 40 60 80 100>;
>> +		default-brightness-level = <2>;
>> +
>> +		power-supply = <&vdd_12v_reg>;               /* VDD */
>> +		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
>> +	};
>> +
>> +	panel {
>> +		compatible = "sharp,lq150x1lg11";
>> +
>> +		power-supply = <&vcc_3v3_reg>;               /* VCC */
>> +
>> +		backlight = <&backlight>;
>> +		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
>> +		lvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;    /* SELLVDS */
>> +	};
>> -- 
>> 2.1.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring (Arm) Oct. 4, 2016, 1:11 p.m. UTC | #3 
On Mon, Oct 3, 2016 at 11:58 PM, Peter Rosin <peda@axentia.se> wrote:
> On 2016-10-03 20:46, Rob Herring wrote:
>> On Tue, Sep 27, 2016 at 12:27:11AM +0200, Peter Rosin wrote:
>>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
>>>
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>>>  1 file changed, 36 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>> new file mode 100644
>>> index 000000000000..715ff7e332f2
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
>>> @@ -0,0 +1,36 @@
>>> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq150x1lg11"
>>> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
>>
>> Should be named according to the input, so vcc-supply.
>
> Right, I wanted to do that, but the simple-panel bindings has power-supply
> as required and I desperately wanted to be compatible in order to make use
> of the simple-panel driver. That driver does require this entry, so I do
> not see any way around it. Any advice for this situation?

Okay, it's fine given it's a single supply.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
new file mode 100644
index 000000000000..715ff7e332f2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
@@ -0,0 +1,36 @@ 
+Sharp 15" LQ150X1LG11 XGA TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq150x1lg11"
+- power-supply: regulator to provide the VCC supply voltage (3.3 volts)
+
+Optional properties:
+- backlight: phandle of the backlight device
+- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
+- lvds-gpios: a single GPIO for the SELLVDS pin.
+
+If lrud-gpios and/or ldvs-gpios are not specified, the RL/UD and/or SELLVDS
+pins are assumed to be handled appropriately by the hardware.
+
+Example:
+
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 0 100000>;                      /* VBR */
+
+		brightness-levels = <0 20 40 60 80 100>;
+		default-brightness-level = <2>;
+
+		power-supply = <&vdd_12v_reg>;               /* VDD */
+		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
+	};
+
+	panel {
+		compatible = "sharp,lq150x1lg11";
+
+		power-supply = <&vcc_3v3_reg>;               /* VCC */
+
+		backlight = <&backlight>;
+		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
+		lvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;    /* SELLVDS */
+	};