| Message ID | 1474963791-3717-1-git-send-email-hadarh@mellanox.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Sep 27, 2016 at 11:09 AM, Hadar Hen Zion <hadarh@mellanox.com> wrote: > Currently the created tc actions list is reversed against the order > set by the user. > Change the actions list order to be the same as was set by the user. > > This patch doesn't affect dump actions behavior. > For dumping, action->order parameter is used so the list order doesn't > matter. > > Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com> > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Changes from V1: - Add a comment to the change log > --- > include/net/pkt_cls.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h > index 5ccaa4b..767b03a 100644 > --- a/include/net/pkt_cls.h > +++ b/include/net/pkt_cls.h > @@ -123,7 +123,7 @@ static inline void tcf_exts_to_list(const struct tcf_exts *exts, > for (i = 0; i < exts->nr_actions; i++) { > struct tc_action *a = exts->actions[i]; > > - list_add(&a->list, actions); > + list_add_tail(&a->list, actions); > } > #endif > } > -- > 1.8.3.1 >
On Tue, Sep 27, 2016 at 1:09 AM, Hadar Hen Zion <hadarh@mellanox.com> wrote: > Currently the created tc actions list is reversed against the order > set by the user. > Change the actions list order to be the same as was set by the user. > > This patch doesn't affect dump actions behavior. > For dumping, action->order parameter is used so the list order doesn't > matter. > > Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com> > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Thanks for updating changelog!
From: Hadar Hen Zion <hadarh@mellanox.com> Date: Tue, 27 Sep 2016 11:09:51 +0300 > Currently the created tc actions list is reversed against the order > set by the user. > Change the actions list order to be the same as was set by the user. > > This patch doesn't affect dump actions behavior. > For dumping, action->order parameter is used so the list order doesn't > matter. > > Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com> > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Applied, thanks.
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 5ccaa4b..767b03a 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -123,7 +123,7 @@ static inline void tcf_exts_to_list(const struct tcf_exts *exts, for (i = 0; i < exts->nr_actions; i++) { struct tc_action *a = exts->actions[i]; - list_add(&a->list, actions); + list_add_tail(&a->list, actions); } #endif }