| Message ID | 1654835.SEcvPVx4OQ@wasted.cogentembedded.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Sergei, On Tue, Sep 27, 2016 at 12:23 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E > (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 > SoCs, so will share the code/data with them... > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- net-next.orig/drivers/net/ethernet/renesas/Kconfig > +++ net-next/drivers/net/ethernet/renesas/Kconfig > @@ -27,7 +27,7 @@ config SH_ETH > Renesas SuperH Ethernet device driver. > This driver supporting CPUs are: > - SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757, > - R8A7740, R8A777x and R8A779x. > + R8A7740, R8A774x, R8A777x and R8A779x. Surely "R8A7740" is covered by "R8A774x"? :-) However, the "x" is not a real wildcard (also for '7x and '9x), as the driver doesn't support all possible values of "x". Apart from that: Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 09/27/2016 10:35 AM, Geert Uytterhoeven wrote: >> Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E >> (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 >> SoCs, so will share the code/data with them... >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> --- net-next.orig/drivers/net/ethernet/renesas/Kconfig >> +++ net-next/drivers/net/ethernet/renesas/Kconfig >> @@ -27,7 +27,7 @@ config SH_ETH >> Renesas SuperH Ethernet device driver. >> This driver supporting CPUs are: >> - SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757, >> - R8A7740, R8A777x and R8A779x. >> + R8A7740, R8A774x, R8A777x and R8A779x. > > Surely "R8A7740" is covered by "R8A774x"? :-) It should be, yes -- but 7740 has completely different Ether core than the RZ/G family. I can fix this if you want... > However, the "x" is not a real wildcard (also for '7x and '9x), as the driver > doesn't support all possible values of "x". Well, I think for 779x it does, provided that the Ether core exists at all. For 777x it doesn't support the SH flavour of 7778 indeed but it's not supported by the kernel at all... > Apart from that: > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you. :-) > Gr{oetje,eeting}s, > > Geert MBR, Sergei
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Tue, 27 Sep 2016 01:23:26 +0300 > Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E > (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 > SoCs, so will share the code/data with them... > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the DaveM's 'net-next.git' repo. > > Re-sending with the DT maintainers/list included this time... Applied, thanks Sergei.
Index: net-next/Documentation/devicetree/bindings/net/sh_eth.txt =================================================================== --- net-next.orig/Documentation/devicetree/bindings/net/sh_eth.txt +++ net-next/Documentation/devicetree/bindings/net/sh_eth.txt @@ -5,6 +5,8 @@ interface contains. Required properties: - compatible: "renesas,gether-r8a7740" if the device is a part of R8A7740 SoC. + "renesas,ether-r8a7743" if the device is a part of R8A7743 SoC. + "renesas,ether-r8a7745" if the device is a part of R8A7745 SoC. "renesas,ether-r8a7778" if the device is a part of R8A7778 SoC. "renesas,ether-r8a7779" if the device is a part of R8A7779 SoC. "renesas,ether-r8a7790" if the device is a part of R8A7790 SoC. Index: net-next/drivers/net/ethernet/renesas/Kconfig =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/Kconfig +++ net-next/drivers/net/ethernet/renesas/Kconfig @@ -27,7 +27,7 @@ config SH_ETH Renesas SuperH Ethernet device driver. This driver supporting CPUs are: - SH7619, SH7710, SH7712, SH7724, SH7734, SH7763, SH7757, - R8A7740, R8A777x and R8A779x. + R8A7740, R8A774x, R8A777x and R8A779x. config RAVB tristate "Renesas Ethernet AVB support" Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -2959,6 +2959,8 @@ static struct sh_eth_plat_data *sh_eth_p static const struct of_device_id sh_eth_match_table[] = { { .compatible = "renesas,gether-r8a7740", .data = &r8a7740_data }, + { .compatible = "renesas,ether-r8a7743", .data = &r8a779x_data }, + { .compatible = "renesas,ether-r8a7745", .data = &r8a779x_data }, { .compatible = "renesas,ether-r8a7778", .data = &r8a777x_data }, { .compatible = "renesas,ether-r8a7779", .data = &r8a777x_data }, { .compatible = "renesas,ether-r8a7790", .data = &r8a779x_data },
Add support for the first two members of the Renesas RZ/G family, RZ/G1M/E (also known as R8A7743/5). The Ether core is the same as in the R-Car gen2 SoCs, so will share the code/data with them... Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the DaveM's 'net-next.git' repo. Re-sending with the DT maintainers/list included this time... Documentation/devicetree/bindings/net/sh_eth.txt | 2 ++ drivers/net/ethernet/renesas/Kconfig | 2 +- drivers/net/ethernet/renesas/sh_eth.c | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)