diff mbox

[U-Boot,9/9] dtoc: Make integer division python 3.x safe

Message ID 20160926143036.5746-10-paul.burton@imgtec.com
State Accepted
Commit 34c38896357db4aae266b14346927da2cd920de6
Delegated to: Simon Glass
Headers show

Commit Message

Paul Burton Sept. 26, 2016, 2:30 p.m. UTC
If we use the '/' operator then python 3.x will produce a float, and
refuse to multiply the string sequence in Conv_name_to_c by it with:

    TypeError: can't multiply sequence by non-int of type 'float'

Use the '//' operator instead to enforce that we want integer rather
than floating point division.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>

---

 tools/dtoc/dtoc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Sept. 27, 2016, 12:33 a.m. UTC | #1
On 26 September 2016 at 08:30, Paul Burton <paul.burton@imgtec.com> wrote:
> If we use the '/' operator then python 3.x will produce a float, and
> refuse to multiply the string sequence in Conv_name_to_c by it with:
>
>     TypeError: can't multiply sequence by non-int of type 'float'
>
> Use the '//' operator instead to enforce that we want integer rather
> than floating point division.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>
> ---
>
>  tools/dtoc/dtoc.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/tools/dtoc/dtoc.py b/tools/dtoc/dtoc.py
index 4ba8604..ac7ba6c 100755
--- a/tools/dtoc/dtoc.py
+++ b/tools/dtoc/dtoc.py
@@ -60,7 +60,7 @@  def Conv_name_to_c(name):
 def TabTo(num_tabs, str):
     if len(str) >= num_tabs * 8:
         return str + ' '
-    return str + '\t' * (num_tabs - len(str) / 8)
+    return str + '\t' * (num_tabs - len(str) // 8)
 
 class DtbPlatdata:
     """Provide a means to convert device tree binary data to platform data