| Message ID | 1474860866-16406-29-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 5d7ec3d8d3f09293824d1486b33cbe578e896996 |
| Delegated to: | Bin Meng |
| Headers | show |
On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass <sjg@chromium.org> wrote: > We don't have a way of adjusting these at present so it is best to refuse to > export these functions. This can be implemented later if the API is required. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > include/_exports.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Tue, Oct 11, 2016 at 11:16 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass <sjg@chromium.org> wrote: >> We don't have a way of adjusting these at present so it is best to refuse to >> export these functions. This can be implemented later if the API is required. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> include/_exports.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/include/_exports.h b/include/_exports.h index 11beeb2..0b30c9e 100644 --- a/include/_exports.h +++ b/include/_exports.h @@ -13,7 +13,7 @@ EXPORT_FUNC(putc, void, putc, const char) EXPORT_FUNC(puts, void, puts, const char *) EXPORT_FUNC(printf, int, printf, const char*, ...) -#if defined(CONFIG_X86) || defined(CONFIG_PPC) +#if (defined(CONFIG_X86) && !defined(CONFIG_X86_64)) || defined(CONFIG_PPC) EXPORT_FUNC(irq_install_handler, void, install_hdlr, int, interrupt_handler_t, void*)
We don't have a way of adjusting these at present so it is best to refuse to export these functions. This can be implemented later if the API is required. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/_exports.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)