Patchwork [testsuite] XFAIL gcc.dg/pragma-init-fini{,-2}.c on Solaris 8/x86

login
register
mail settings
Submitter Rainer Orth
Date Oct. 11, 2010, 8:11 p.m.
Message ID <ydd1v7w1ode.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/67477/
State New
Headers show

Comments

Rainer Orth - Oct. 11, 2010, 8:11 p.m.
The gcc.dg/pragma-init-fini*.c tests fail on Solaris 8/x86 with Sun as
because that assembler version (unlike Solaris 8/SPARC as) doesn't
understand .pushsection/.popsection.

At first I've developed a patch to detect that condition and have gcc
warn about it if the pragma is used, but given the age of that release
and the corner case at hand, I'm now considering this overkill.

Instead I just skip or xfail the two patches.

Already tested with the appropriate runtest invocations; will apply to
mainline, 4.4 and 4.5 branches after regtesting completes.

	Rainer


2010-10-09  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* gcc.dg/pragma-init-fini.c: Skip on i?86-*-solaris2.8 && !gas.
	* gcc.dg/pragma-init-fini-2.c: XFAIL on i?86-*-solaris2.8 && !gas.

Patch

diff -r 83e972c2953f gcc/testsuite/gcc.dg/pragma-init-fini-2.c
--- a/gcc/testsuite/gcc.dg/pragma-init-fini-2.c	Sat Oct 09 16:30:43 2010 +0200
+++ b/gcc/testsuite/gcc.dg/pragma-init-fini-2.c	Sat Oct 09 17:18:43 2010 +0200
@@ -2,6 +2,7 @@ 
 
 /* { dg-do link { target *-*-solaris2.* } } */
 /* { dg-options "-fpic" } */
+/* { dg-xfail-if "no .pushsection/.popsection" { i?86-*-solaris2.8 && { ! gas } } } */
 
 #include <stdio.h>
 
diff -r 83e972c2953f gcc/testsuite/gcc.dg/pragma-init-fini.c
--- a/gcc/testsuite/gcc.dg/pragma-init-fini.c	Sat Oct 09 16:30:43 2010 +0200
+++ b/gcc/testsuite/gcc.dg/pragma-init-fini.c	Sat Oct 09 17:18:43 2010 +0200
@@ -1,6 +1,7 @@ 
 /* Tests for #pragma init and #pragma fini.  */
 
 /* { dg-do run { target *-*-solaris2.* } } */
+/* { dg-skip-if "no .pushsection/.popsection" { i?86-*-solaris2.8 && { ! gas } } } */
 
 extern void abort ();