[v2] mksh: add new package MirOS Korn Shell

The MirOS Korn Shell is a quite complete posix shell implementation,
is rather small and supports vi mode properly.

Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
v1 -> v2:
  - added hash file
  - updated to latest release
  - tested with shared and static builds
---
I am resending the patch from Kurt, not sure why he got no feedback
yet. I can take over maintainership (DEVELOPERS entry), if Kurt won't do it.
It is a great shell and if you ever try to debug functions in ash
with set -x, you know why you want to switch to mksh.
It should properly cross-compile for every supported buildroot
architecture with MMU. It is used for a long time in OpenADK as
base system shell and it is pretty stable.
---
 package/Config.in      |  1 +
 package/mksh/Config.in | 22 ++++++++++++++++++++++
 package/mksh/mksh.hash |  4 ++++
 package/mksh/mksh.mk   | 31 +++++++++++++++++++++++++++++++
 system/Config.in       |  9 ++++++++-
 5 files changed, 66 insertions(+), 1 deletion(-)
 create mode 100644 package/mksh/Config.in
 create mode 100644 package/mksh/mksh.hash
 create mode 100644 package/mksh/mksh.mk

Hello,

On Thu, 22 Sep 2016 20:12:54 +0200, Waldemar Brodkorb wrote:
> The MirOS Korn Shell is a quite complete posix shell implementation,
> is rather small and supports vi mode properly.
> 
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

I was about to apply this, but there's an issue with the licensing. So
while I'm at it, I'm also giving other comments.

The title should be just:

	mksh: new package


> --- /dev/null
> +++ b/package/mksh/Config.in
> @@ -0,0 +1,22 @@
> +config BR2_PACKAGE_MKSH
> +	bool "mksh"
> +	depends on BR2_USE_MMU # fork()
> +	help
> +	  The MirBSD Korn Shell,
> +
> +	  mksh is a successor of pdksh but not affiliated with the pdksh
> +	  developers or contributors. mksh is not affiliated with the
> +	  AT&T Korn Shell, its past or present owners, other than that
> +	  both attempt to implement the Korn Shell programming language.
> +
> +	  mksh targets users who desire a compact, fast, reliable,
> +	  secure shell not cut off modern extensions; a shell with
> +	  Unicode support; an actively developed, current, and portable
> +	  product; one with developers that listen to their users’ requests
> +	  and implement them if they actually make sense.
> +
> +	  mksh aims to replace pdksh in all but very rare use cases
> +	  (such as support for checking the Unix mbox) and in all operating
> +	  environments (thus including patches from pdksh on e.g. Debian).

Those lines are too long. Please wrap the help text to a length of 72
characters per line.

> +MKSH_VERSION = R53a
> +MKSH_SOURCE = mksh-$(MKSH_VERSION).tgz
> +MKSH_SITE = https://www.mirbsd.org/MirOS/dist/mir/mksh
> +MKSH_LICENSE = MirOS, BSD-3c, ISC
> +MKSH_LICENSE_FILES = COPYING

There is no COPYING file in the source code, so this will cause build
failure.

Where is the information about the licensing coming from? What is this
"MirOS" license?

The man page references https://www.mirbsd.org/TaC-mksh.txt as
containing the legalese. Maybe this needs to also be downloaded, and
used as a license file. At least they clarify what this "MirOS" license
is.
> +define MKSH_CONFIGURE_CMDS
> +	cd $(@D) && $(TARGET_MAKE_ENV) \
> +		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
> +		CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
> +		LD="$(TARGET_LD)" LDFLAGS="$(TARGET_LDFLAGS)" LDLIBS="$(TARGET_LDLIBS)" \

TARGET_LDLIBS does not exist. Have you considered using $(TARGET_CONFIGURE_OPTS) here?

	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
		TARGET_OS=Linux \
		sh ./Build.sh -M

> diff --git a/system/Config.in b/system/Config.in
> index 77c665b..d3b2889 100644

The changes in this file could possibly go to a separate patch.

Thanks!

Thomas

Hi Thorsten,
Thorsten Glaser wrote,

> Waldemar Brodkorb dixit:
> 
> >The MirOS Korn Shell is a quite complete posix shell implementation,
> 
> POSIX compatible, not 100% but closer than most others…
> 
> >+MKSH_LICENSE = MirOS, BSD-3c, ISC
> 
> Only MirOS and ISC unless you add printf.c (which I don’t see
> in the patch).
> 
> >+MKSH_LICENSE_FILES = COPYING
> 
> Huh?

Okay, seems to be a problem.
Is the License file for mksh (MirOS License) available in 
a file in the source tree?
Buildroot has a function to collect all license files of
a created root filesystem.

> >+define MKSH_CONFIGURE_CMDS
> >+	cd $(@D) && $(TARGET_MAKE_ENV) \
> >+		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
> 
> You only need -DMKSH_S_NOVI=0 if you also add -DMKSH_SMALL
> and want the vi editing mode.
> 
> >+		sh ./Build.sh -M
> >+endef
> >+
> >+define MKSH_BUILD_CMDS
> >+	cd $(@D) && $(TARGET_MAKE_ENV) \
> >+		sh ./Rebuild.sh
> >+endef
> 
> Arguable, but just call Build.sh without -M to configure *and*
> build it in *one* step.
> 
> >+define MKSH_INSTALL_TARGET_CMDS
> >+	$(INSTALL) -m 0755 $(@D)/mksh $(TARGET_DIR)/bin/mksh
> >+endef
> 
> Please also ship dot.mkshrc or some other sort of ~/.mkshrc
> so that users get a slightly more comfortable/usable environment,
> if you can afford it, byte-wise (it’s 15K), or at least make it
> configurable. (Also patch it, if needed, e.g. for an ls(1) without
> the -o option.)
> 
> Thanks,
> //mirabilos (mksh upstream)

thx,
 Waldemar