Patchwork [take2] Make LTO plugin object-file-format- and host- independent.

login
register
mail settings
Submitter H.J. Lu
Date Oct. 9, 2010, 5:04 a.m.
Message ID <AANLkTimtQLbjMFjMjW3XYQZyJWu_8Bw4QN4MDO1qrBfq@mail.gmail.com>
Download mbox | patch
Permalink /patch/67314/
State New
Headers show

Comments

H.J. Lu - Oct. 9, 2010, 5:04 a.m.
On Fri, Oct 8, 2010 at 9:45 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Oct 7, 2010 at 1:52 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
>> On 06/10/2010 23:23, Dave Korn wrote:
>>> On 06/10/2010 19:33, Richard Henderson wrote:
>>
>>>> Patch is ok.
>>>
>>>   Thanks :)
>>
>>  Committed revision 165133.  Will sync top-level to src/ in a few minutes.
>>
>
> This caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45951
>

We can't do

. ${srcdir}/../gcc/config.gcc
case ${lto_binary_reader} in
  *coff*) LTO_FORMAT=coff ;;
  *elf*)  LTO_FORMAT=elf ;;
  *) AC_MSG_ERROR([LTO plugin is not supported on this target.]) ;;
esac

with noncanonical target. I am checking this patch as an obvious fix.
Dave Korn - Oct. 9, 2010, 10:39 a.m.
On 09/10/2010 06:04, H.J. Lu wrote:
> On Fri, Oct 8, 2010 at 9:45 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Oct 7, 2010 at 1:52 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
>>> On 06/10/2010 23:23, Dave Korn wrote:
>>>> On 06/10/2010 19:33, Richard Henderson wrote:
>>>>> Patch is ok.
>>>>   Thanks :)
>>>  Committed revision 165133.  Will sync top-level to src/ in a few minutes.
>>>
>> This caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45951
>>
> 
> We can't do
> 
> . ${srcdir}/../gcc/config.gcc
> case ${lto_binary_reader} in
>   *coff*) LTO_FORMAT=coff ;;
>   *elf*)  LTO_FORMAT=elf ;;
>   *) AC_MSG_ERROR([LTO plugin is not supported on this target.]) ;;
> esac
> 
> with noncanonical target. I am checking this patch as an obvious fix.

  Thank you HJ, sorry for the inconvenience.

    cheers,
      DaveK

Patch

diff --git a/lto-plugin/configure.ac b/lto-plugin/configure.ac
index c43b264..4d9380e 100644
--- a/lto-plugin/configure.ac
+++ b/lto-plugin/configure.ac
@@ -1,5 +1,6 @@ 
 AC_PREREQ(2.64)
 AC_INIT([LTO plugin for ld], 0.1,,[lto-plugin])
+AC_CANONICAL_SYSTEM
 GCC_TOPLEV_SUBDIRS
 AM_INIT_AUTOMAKE([foreign no-dist])
 AM_MAINTAINER_MODE