Patchwork [08/12] cris: avoid a write only variable

login
register
mail settings
Submitter Blue Swirl
Date Oct. 8, 2010, 9:24 p.m.
Message ID <AANLkTik_j-EXLriEAMzMH41KGTfQqrCGREnuPzv6vSq=@mail.gmail.com>
Download mbox | patch
Permalink /patch/67298/
State New
Headers show

Comments

Blue Swirl - Oct. 8, 2010, 9:24 p.m.
Compiling with GCC 4.6.0 20100925 produced a warning:
In file included from /src/qemu/target-cris/translate.c:3154:0:
/src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
/src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set
but not used [-Werror=unused-but-set-variable]

Fix by deleting rd, adjust the only user.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-cris/translate_v10.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

     if (is_imm) {

Patch

diff --git a/target-cris/translate_v10.c b/target-cris/translate_v10.c
index 14e590d..6944827 100644
--- a/target-cris/translate_v10.c
+++ b/target-cris/translate_v10.c
@@ -108,16 +108,15 @@  static unsigned int
crisv10_post_memaddr(DisasContext *dc, unsigned int size)
 static int dec10_prep_move_m(DisasContext *dc, int s_ext, int memsize,
                            TCGv dst)
 {
-    unsigned int rs, rd;
+    unsigned int rs;
     uint32_t imm;
     int is_imm;
     int insn_len = 0;

     rs = dc->src;
-    rd = dc->dst;
     is_imm = rs == 15 && !(dc->tb_flags & PFIX_FLAG);
     LOG_DIS("rs=%d rd=%d is_imm=%d mode=%d pfix=%d\n",
-             rs, rd, is_imm, dc->mode, dc->tb_flags & PFIX_FLAG);
+             rs, dc->dst, is_imm, dc->mode, dc->tb_flags & PFIX_FLAG);

     /* Load [$rs] onto T1.  */