[v2,2/3] mmc: sh_mmcif: Document r7s72100 DT bindings

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
v2:
* added interrupt description
---
 Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++++
 1 file changed, 4 insertions(+)

On Tue, Sep 20, 2016 at 11:46:19AM -0400, Chris Brandt wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
> v2:
> * added interrupt description
> ---
>  Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> index ff611fa..1443edb 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> @@ -8,12 +8,16 @@ Required properties:
>  
>  - compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif" as a
>    fallback. Examples with <soctype> are:
> +	- "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs
>  	- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>  	- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>  	- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>  	- "renesas,mmcif-r8a7793" for the MMCIF found in r8a7793 SoCs
>  	- "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
>  
> +- interrupts: either 1 shared interrupt, 2 separate interrupts (error and int),
> +  or 3 separate interrupts (error, int, card detect)

This should be based on the compatible strings. Surely, 1, 2, or 3 is 
not valid for all compatibles.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On 9/23/2016, Rob Herring wrote:
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > index ff611fa..1443edb 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > @@ -8,12 +8,16 @@ Required properties:
> >
> >  - compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif"
> as a
> >    fallback. Examples with <soctype> are:
> > +	- "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs
> >  	- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
> >  	- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
> >  	- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
> >  	- "renesas,mmcif-r8a7793" for the MMCIF found in r8a7793 SoCs
> >  	- "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
> >
> > +- interrupts: either 1 shared interrupt, 2 separate interrupts (error
> > +and int),
> > +  or 3 separate interrupts (error, int, card detect)
> 
> This should be based on the compatible strings. Surely, 1, 2, or 3 is not
> valid for all compatibles.


That is true. What is your suggestion? Add the specific number of interrupts for each SoC to the documentation so there is no confusion?

For example:

- interrupts: Some SoCs have only 1 shared interrupt, while others have either
  2 or 3 individual interrupts (error, int, card detect). Below is the number
  of interrupts for each SoC.
    3: r7s72100 SoC
    2: r8a7740 SoC
    1: r8a7790 SoC
    1: r8a7791 SoC
    1: r8a7793 SoC
    1: r8a7794 SoC


Chris
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html