[4/4] Phonet: mark the pipe controller as EXPERIMENTAL

From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

There are a bunch of issues that need to be fixed, including:
 - GFP_KERNEL allocations from atomic context
   (and GFP_ATOMIC in process context),
 - abuse of the setsockopt() call convention,
 - unprotected/unlocked static variables...

IMHO, we will need to alter the userspace ABI when we fix it. So mark
the configuration option as EXPERIMENTAL for the time being (or should
it be BROKEN instead?).

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
---
 net/phonet/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

From: Rémi Denis-Courmont <remi@remlab.net>
Date: Fri,  8 Oct 2010 17:02:03 +0300

> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
> 
> There are a bunch of issues that need to be fixed, including:
>  - GFP_KERNEL allocations from atomic context
>    (and GFP_ATOMIC in process context),
>  - abuse of the setsockopt() call convention,
>  - unprotected/unlocked static variables...
> 
> IMHO, we will need to alter the userspace ABI when we fix it. So mark
> the configuration option as EXPERIMENTAL for the time being (or should
> it be BROKEN instead?).
> 
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Fri, Oct 08, 2010 at 16:02:03 +0200, Rémi Denis-Courmont wrote:
> From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
> 
> There are a bunch of issues that need to be fixed, including:
>  - GFP_KERNEL allocations from atomic context
>    (and GFP_ATOMIC in process context),
>  - abuse of the setsockopt() call convention,
>  - unprotected/unlocked static variables...
> 
> IMHO, we will need to alter the userspace ABI when we fix it. So mark
> the configuration option as EXPERIMENTAL for the time being (or should
> it be BROKEN instead?).
> 
> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Thank you for this patch.
I have already started implementing 'connect()' socket call for Pipe
controller logic, as per advise of Rémi Denis-Courmontt. I will upload
this patch for review once I have validated GPRS/3G path (control/data)
to be working fine.

Hopefully, with all the reviews and suggestions shared on the mailing
list, existing abuse can be removed and new abuses can be avoided.

The only intention of submitting is to make Linux work smoothly with
newer devices. If there is some improper code getting introduced
unknowingly, then I will surely work on the review comments to fix it.

Thank you all!

Best regards,
Kumar.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Mon, 11 Oct 2010 12:39:29 +0530, Kumar SANGHVI
<kumar.sanghvi@stericsson.com> wrote:
> I have already started implementing 'connect()' socket call for Pipe
> controller logic, as per advise of Rémi Denis-Courmontt. I will upload
> this patch for review once I have validated GPRS/3G path (control/data)
> to be working fine.
> 
> Hopefully, with all the reviews and suggestions shared on the mailing
> list, existing abuse can be removed and new abuses can be avoided.
> 
> The only intention of submitting is to make Linux work smoothly with
> newer devices. If there is some improper code getting introduced
> unknowingly, then I will surely work on the review comments to fix it.

I am sure everybody wants to get things right eventually. That's not much
of a concern to me.

However, I am concerned that Linux 2.6.37 ships with an unfinished
implementation, or worse, an unfinished user-space interface.