mbox

[PULL,v2,0/8] Merge qcrypto 2016/09/19

Message ID 1474299237-1054-1-git-send-email-berrange@redhat.com
State New
Headers show

Pull-request

git://github.com/berrange/qemu tags/pull-qcrypto-2016-09-19-2

Message

Daniel P. Berrangé Sept. 19, 2016, 3:33 p.m. UTC 
The following changes since commit 0f2fa73ba0ca19ebdaccf0d1785583d6601411b6:

  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-19 11:23:20 +0100)

are available in the git repository at:

  git://github.com/berrange/qemu tags/pull-qcrypto-2016-09-19-2

for you to fetch changes up to b57482d7a0fe669aeb6f0c3c3503d143b9db89dd:

  crypto: add trace points for TLS cert verification (2016-09-19 16:30:46 +0100)

----------------------------------------------------------------
Merge qcrypto 2016/09/19 v2

----------------------------------------------------------------
Daniel P. Berrange (8):
      crypto: use uint64_t for pbkdf iteration count parameters
      crypto: make PBKDF iterations configurable for LUKS format
      crypto: clear out buffer after timing pbkdf algorithm
      crypto: use correct derived key size when timing pbkdf
      crypto: remove bogus /= 2 for pbkdf iterations
      crypto: increase default pbkdf2 time for luks to 2 seconds
      crypto: support more hash algorithms for pbkdf
      crypto: add trace points for TLS cert verification

 block/crypto.c            |  6 ++++++
 crypto/block-luks.c       | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
 crypto/pbkdf-gcrypt.c     | 21 +++++++++++++++++++--
 crypto/pbkdf-nettle.c     | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------
 crypto/pbkdf-stub.c       |  2 +-
 crypto/pbkdf.c            | 35 +++++++++++++++++++----------------
 crypto/tlssession.c       | 10 ++++++++--
 crypto/trace-events       |  1 +
 include/crypto/pbkdf.h    | 16 ++++++++++------
 qapi/crypto.json          |  6 +++++-
 tests/test-crypto-pbkdf.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 11 files changed, 238 insertions(+), 62 deletions(-)

Comments

no-reply@patchew.org Sept. 19, 2016, 3:55 p.m. UTC | #1 
Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016/09/19
Message-id: 1474299237-1054-1-git-send-email-berrange@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e82628e crypto: add trace points for TLS cert verification
9d93d38 crypto: support more hash algorithms for pbkdf
08053a6 crypto: increase default pbkdf2 time for luks to 2 seconds
657e1cd crypto: remove bogus /= 2 for pbkdf iterations
d3206e1 crypto: use correct derived key size when timing pbkdf
435e4e2 crypto: clear out buffer after timing pbkdf algorithm
cce8751 crypto: make PBKDF iterations configurable for LUKS format
2f624b1 crypto: use uint64_t for pbkdf iteration count parameters

=== OUTPUT BEGIN ===
Checking PATCH 1/8: crypto: use uint64_t for pbkdf iteration count parameters...
Checking PATCH 2/8: crypto: make PBKDF iterations configurable for LUKS format...
Checking PATCH 3/8: crypto: clear out buffer after timing pbkdf algorithm...
Checking PATCH 4/8: crypto: use correct derived key size when timing pbkdf...
Checking PATCH 5/8: crypto: remove bogus /= 2 for pbkdf iterations...
Checking PATCH 6/8: crypto: increase default pbkdf2 time for luks to 2 seconds...
Checking PATCH 7/8: crypto: support more hash algorithms for pbkdf...
ERROR: if this code is redundant consider removing it
#222: FILE: tests/test-crypto-pbkdf.c:332:
+#if 0

total: 1 errors, 0 warnings, 194 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/8: crypto: add trace points for TLS cert verification...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Peter Maydell Sept. 19, 2016, 5:06 p.m. UTC | #2 
On 19 September 2016 at 16:33, Daniel P. Berrange <berrange@redhat.com> wrote:
> The following changes since commit 0f2fa73ba0ca19ebdaccf0d1785583d6601411b6:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-19 11:23:20 +0100)
>
> are available in the git repository at:
>
>   git://github.com/berrange/qemu tags/pull-qcrypto-2016-09-19-2
>
> for you to fetch changes up to b57482d7a0fe669aeb6f0c3c3503d143b9db89dd:
>
>   crypto: add trace points for TLS cert verification (2016-09-19 16:30:46 +0100)
>
> ----------------------------------------------------------------
> Merge qcrypto 2016/09/19 v2
>
> ----------------------------------------------------------------
> Daniel P. Berrange (8):
>       crypto: use uint64_t for pbkdf iteration count parameters
>       crypto: make PBKDF iterations configurable for LUKS format
>       crypto: clear out buffer after timing pbkdf algorithm
>       crypto: use correct derived key size when timing pbkdf
>       crypto: remove bogus /= 2 for pbkdf iterations
>       crypto: increase default pbkdf2 time for luks to 2 seconds
>       crypto: support more hash algorithms for pbkdf
>       crypto: add trace points for TLS cert verification
>

Applied, thanks.

-- PMM
no-reply@patchew.org Sept. 19, 2016, 8:16 p.m. UTC | #3 
Hi,

Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.

Type: series
Subject: [Qemu-devel] [PULL v2 0/8] Merge qcrypto 2016/09/19
Message-id: 1474299237-1054-1-git-send-email-berrange@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
make J=8 docker-test-quick@centos6
make J=8 docker-test-mingw@fedora
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e82628e crypto: add trace points for TLS cert verification
9d93d38 crypto: support more hash algorithms for pbkdf
08053a6 crypto: increase default pbkdf2 time for luks to 2 seconds
657e1cd crypto: remove bogus /= 2 for pbkdf iterations
d3206e1 crypto: use correct derived key size when timing pbkdf
435e4e2 crypto: clear out buffer after timing pbkdf algorithm
cce8751 crypto: make PBKDF iterations configurable for LUKS format
2f624b1 crypto: use uint64_t for pbkdf iteration count parameters

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
  BUILD centos6
=== OUTPUT END ===

Abort: command timeout (>3600 seconds)


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org