| Message ID | 1474232179-19811-3-git-send-email-olivier.schonken@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Sun, 18 Sep 2016 22:56:19 +0200, Olivier Schonken wrote: > +ifeq ($(BR2_STATIC_LIBS),y) > +OPENJPEG_CONF_OPTS = -DBUILD_THIRDPARTY=ON > +endif If I understand correctly, this tells OpenJPEG to build its internal copy of lzma, tiff and other libraries. Is this correct? If it is, then it is not the proper solution to the problem. Regardless of whether we're static linking or dynamic linking, we want to use the external libraries (i.e provided by the corresponding Buildroot packages). Also, your commit log lacks a reference to the autobuilder failure being fixed (I know they are in the cover letter, but the cover letter doesn't get committed, which is why we want the explanation and the autobuilder reference to be in the commit lot itself). Thanks, Thomas
diff --git a/package/openjpeg/openjpeg.mk b/package/openjpeg/openjpeg.mk index bf12526..08192a7 100644 --- a/package/openjpeg/openjpeg.mk +++ b/package/openjpeg/openjpeg.mk @@ -9,6 +9,9 @@ OPENJPEG_SITE = $(call github,uclouvain,openjpeg,version.$(OPENJPEG_VERSION)) OPENJPEG_LICENSE = BSD-2c OPENJPEG_LICENSE_FILES = LICENSE OPENJPEG_INSTALL_STAGING = YES +ifeq ($(BR2_STATIC_LIBS),y) +OPENJPEG_CONF_OPTS = -DBUILD_THIRDPARTY=ON +endif OPENJPEG_DEPENDENCIES += $(if $(BR2_PACKAGE_ZLIB),zlib) OPENJPEG_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBPNG),libpng)
Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com> --- package/openjpeg/openjpeg.mk | 3 +++ 1 file changed, 3 insertions(+)