Patchwork [6/7] Clarify default values in migration speed argument in monitor

login
register
mail settings
Submitter Jes Sorensen
Date Oct. 8, 2010, 9:15 a.m.
Message ID <1286529360-5715-7-git-send-email-Jes.Sorensen@redhat.com>
Download mbox | patch
Permalink /patch/67143/
State New
Headers show

Comments

Jes Sorensen - Oct. 8, 2010, 9:15 a.m.
From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 hmp-commands.hx |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Paolo Bonzini - Oct. 8, 2010, 4:21 p.m.
On 10/08/2010 11:15 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
> ---
>   hmp-commands.hx |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 95bdb91..f138a76 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -756,7 +756,8 @@ ETEXI
>           .name       = "migrate_set_speed",
>           .args_type  = "value:o",
>           .params     = "value",
> -        .help       = "set maximum speed (in bytes) for migrations",
> +        .help       = "set maximum speed (in bytes) for migrations. "
> +	"Defaults to KB if no size suffix is specified, ie. K/M/G/T",
                      ^^

To MB, no?

Paolo
Jes Sorensen - Oct. 11, 2010, 6:45 a.m.
On 10/08/10 18:21, Paolo Bonzini wrote:
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 95bdb91..f138a76 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -756,7 +756,8 @@ ETEXI
>>           .name       = "migrate_set_speed",
>>           .args_type  = "value:o",
>>           .params     = "value",
>> -        .help       = "set maximum speed (in bytes) for migrations",
>> +        .help       = "set maximum speed (in bytes) for migrations. "
>> +    "Defaults to KB if no size suffix is specified, ie. K/M/G/T",
>                      ^^
> 
> To MB, no?

DOH, you're right. Re-spin coming up shortly unless I receive anymore
comments.

Cheers,
Jes

Patch

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 95bdb91..f138a76 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -756,7 +756,8 @@  ETEXI
         .name       = "migrate_set_speed",
         .args_type  = "value:o",
         .params     = "value",
-        .help       = "set maximum speed (in bytes) for migrations",
+        .help       = "set maximum speed (in bytes) for migrations. "
+	"Defaults to KB if no size suffix is specified, ie. K/M/G/T",
         .user_print = monitor_user_noop,
         .mhandler.cmd_new = do_migrate_set_speed,
     },