| Message ID | 1474189896-20417-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes] > > In fact, these two functions are not declared in any file, but should > be declared in a header file, thus can be recognized in other file. > > So this patch adds the declarations into > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > Why can't these be declared static? Arnd
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h index 4cbdf14..31f6505 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h @@ -462,4 +462,6 @@ int hns_cpld_led_set_id(struct hns_mac_cb *mac_cb, enum hnae_led_state status); void hns_mac_set_promisc(struct hns_mac_cb *mac_cb, u8 en); +void hns_dsaf_srst_chns(struct dsaf_device *dsaf_dev, u32 msk, bool dereset); +void hns_dsaf_roce_srst(struct dsaf_device *dsaf_dev, bool dereset); #endif /* _HNS_DSAF_MAC_H */
We get 2 warnings when building kernel with W=1: drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes] drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes] In fact, these two functions are not declared in any file, but should be declared in a header file, thus can be recognized in other file. So this patch adds the declarations into drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h | 2 ++ 1 file changed, 2 insertions(+)