| Message ID | 1474058133-27363-5-git-send-email-tpearson@raptorengineering.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Sat, Sep 17, 2016 at 6:05 AM, Timothy Pearson <tpearson@raptorengineering.com> wrote: > This is required for Firestone networking to function correctly. > This should not be required. Can you please test without this patch and see if networking works? > Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> > --- > drivers/net/ethernet/faraday/ftgmac100.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c > index 778c625..3a6367d 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c > @@ -1423,8 +1423,7 @@ static int ftgmac100_probe(struct platform_device *pdev) > * in that case. > */ > netdev->features = NETIF_F_IP_CSUM | NETIF_F_GRO; > - if (priv->use_ncsi && > - of_get_property(pdev->dev.of_node, "no-hw-checksum", NULL)) > + if (of_get_property(pdev->dev.of_node, "no-hw-checksum", NULL)) > netdev->features &= ~NETIF_F_IP_CSUM; > > > -- > 1.7.9.5 > > _______________________________________________ > openbmc mailing list > openbmc@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/openbmc
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/23/2016 01:57 AM, Joel Stanley wrote: > On Sat, Sep 17, 2016 at 6:05 AM, Timothy Pearson > <tpearson@raptorengineering.com> wrote: >> This is required for Firestone networking to function correctly. >> I did. It did not work. DHCP and ping worked but anything more complex failed; SSH connections timed out, no HTTP access, etc. - -- Timothy Pearson Raptor Engineering +1 (415) 727-8645 (direct line) +1 (512) 690-0200 (switchboard) https://www.raptorengineering.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJX5UPBAAoJEK+E3vEXDOFbRakH/3g6MII/5bEXjQJiBw9n8AiR av3vtBecuhaF/hk/wJbxf8LkZKg6gdXTGxy57AY2om/lxv3J/3fYfYzDeV0Y5j8u k6QTJxFea1XK7Pjj5YlqZ9/58wlN3BGef9X+eQXZOMMGbAYfyTJ5AAf69mOcML45 yazvdzu8+hmrKUX2HFrpzZQ2KCQ3TK9bthDLm3PXicE4f5BYjoOBGJu0Zm2+38Mt 1H8XkMNoJP8r2tcsrX01awR56AqDfctdp06oOhKrLpTsyizxNkTwnOqOO84B8eGA a9axVamYiHQ+zGqAHtmrX2AWUr8yLK0Dl8YJC8zTNXz+vUPXstsE02ak24Jc7Ko= =Hr8f -----END PGP SIGNATURE-----
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 778c625..3a6367d 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1423,8 +1423,7 @@ static int ftgmac100_probe(struct platform_device *pdev) * in that case. */ netdev->features = NETIF_F_IP_CSUM | NETIF_F_GRO; - if (priv->use_ncsi && - of_get_property(pdev->dev.of_node, "no-hw-checksum", NULL)) + if (of_get_property(pdev->dev.of_node, "no-hw-checksum", NULL)) netdev->features &= ~NETIF_F_IP_CSUM;
This is required for Firestone networking to function correctly. Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com> --- drivers/net/ethernet/faraday/ftgmac100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)