Patchwork UBUNTU: [Config] enable passing all kernel command line to init

login
register
mail settings
Submitter Bryan Wu
Date Oct. 7, 2010, 10:24 p.m.
Message ID <1286490297-4420-2-git-send-email-bryan.wu@canonical.com>
Download mbox | patch
Permalink /patch/67109/
State Accepted
Delegated to: Tim Gardner
Headers show

Comments

Bryan Wu - Oct. 7, 2010, 10:24 p.m.
BugLink: http://bugs.launchpad.net/bugs/586386

For booting on OMAP4 with upstart, we need kernel turn on this option
	CONFIG_INIT_PASS_ALL_PARAMS=y
Otherwise, it cannot boot on some omap4 hardware.

Tested-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 debian.ti-omap4/config/config.common.ubuntu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Eric Miao - Oct. 8, 2010, 1:02 a.m.
On Fri, Oct 8, 2010 at 6:24 AM, Bryan Wu <bryan.wu@canonical.com> wrote:
> BugLink: http://bugs.launchpad.net/bugs/586386
>
> For booting on OMAP4 with upstart, we need kernel turn on this option
>        CONFIG_INIT_PASS_ALL_PARAMS=y
> Otherwise, it cannot boot on some omap4 hardware.

Bryan,

If this is needed by upstart and applicable to all platforms, would it be
better to force that in debian/config/enforce?

>
> Tested-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> ---
>  debian.ti-omap4/config/config.common.ubuntu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index fea641e..ff71324 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1013,7 +1013,7 @@ CONFIG_INET_XFRM_TUNNEL=m
>  CONFIG_INFTL=m
>  CONFIG_INITRAMFS_SOURCE=""
>  CONFIG_INIT_ENV_ARG_LIMIT=32
> -# CONFIG_INIT_PASS_ALL_PARAMS is not set
> +CONFIG_INIT_PASS_ALL_PARAMS=y
>  # CONFIG_INLINE_READ_LOCK is not set
>  # CONFIG_INLINE_READ_LOCK_BH is not set
>  # CONFIG_INLINE_READ_LOCK_IRQ is not set
> --
> 1.7.1
>
>
> --
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Bryan Wu - Oct. 8, 2010, 2:47 p.m.
On Thu, Oct 7, 2010 at 8:02 PM, Eric Miao <eric.miao@canonical.com> wrote:
> On Fri, Oct 8, 2010 at 6:24 AM, Bryan Wu <bryan.wu@canonical.com> wrote:
>> BugLink: http://bugs.launchpad.net/bugs/586386
>>
>> For booting on OMAP4 with upstart, we need kernel turn on this option
>>        CONFIG_INIT_PASS_ALL_PARAMS=y
>> Otherwise, it cannot boot on some omap4 hardware.
>
> Bryan,
>
> If this is needed by upstart and applicable to all platforms, would it be
> better to force that in debian/config/enforce?
>

Yeah, it would be better. But currently we just plan to release
Maverick. I think we can add this enforce check item in Natty.

-Bryan


>> Tested-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>> ---
>>  debian.ti-omap4/config/config.common.ubuntu |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
>> index fea641e..ff71324 100644
>> --- a/debian.ti-omap4/config/config.common.ubuntu
>> +++ b/debian.ti-omap4/config/config.common.ubuntu
>> @@ -1013,7 +1013,7 @@ CONFIG_INET_XFRM_TUNNEL=m
>>  CONFIG_INFTL=m
>>  CONFIG_INITRAMFS_SOURCE=""
>>  CONFIG_INIT_ENV_ARG_LIMIT=32
>> -# CONFIG_INIT_PASS_ALL_PARAMS is not set
>> +CONFIG_INIT_PASS_ALL_PARAMS=y
>>  # CONFIG_INLINE_READ_LOCK is not set
>>  # CONFIG_INLINE_READ_LOCK_BH is not set
>>  # CONFIG_INLINE_READ_LOCK_IRQ is not set
>> --
>> 1.7.1
>>
>>
>> --
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>
>
Leann Ogasawara - Oct. 8, 2010, 5:56 p.m.
On Thu, 2010-10-07 at 17:24 -0500, Bryan Wu wrote:
> BugLink: http://bugs.launchpad.net/bugs/586386
> 
> For booting on OMAP4 with upstart, we need kernel turn on this option
> 	CONFIG_INIT_PASS_ALL_PARAMS=y
> Otherwise, it cannot boot on some omap4 hardware.
> 
> Tested-by: Ricardo Salveti de Araujo <ricardo.salveti@canonical.com>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Looks reasonable to me and only affects ti-omap4.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
>  debian.ti-omap4/config/config.common.ubuntu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index fea641e..ff71324 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1013,7 +1013,7 @@ CONFIG_INET_XFRM_TUNNEL=m
>  CONFIG_INFTL=m
>  CONFIG_INITRAMFS_SOURCE=""
>  CONFIG_INIT_ENV_ARG_LIMIT=32
> -# CONFIG_INIT_PASS_ALL_PARAMS is not set
> +CONFIG_INIT_PASS_ALL_PARAMS=y
>  # CONFIG_INLINE_READ_LOCK is not set
>  # CONFIG_INLINE_READ_LOCK_BH is not set
>  # CONFIG_INLINE_READ_LOCK_IRQ is not set
Brad Figg - Oct. 13, 2010, 8:40 p.m.
On 10/08/2010 10:56 AM, Leann Ogasawara wrote:
> On Thu, 2010-10-07 at 17:24 -0500, Bryan Wu wrote:
>> BugLink: http://bugs.launchpad.net/bugs/586386
>>
>> For booting on OMAP4 with upstart, we need kernel turn on this option
>> 	CONFIG_INIT_PASS_ALL_PARAMS=y
>> Otherwise, it cannot boot on some omap4 hardware.
>>
>> Tested-by: Ricardo Salveti de Araujo<ricardo.salveti@canonical.com>
>> Signed-off-by: Bryan Wu<bryan.wu@canonical.com>
>
> Looks reasonable to me and only affects ti-omap4.
>
> Acked-by: Leann Ogasawara<leann.ogasawara@canonical.com>
>
>> ---
>>   debian.ti-omap4/config/config.common.ubuntu |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
>> index fea641e..ff71324 100644
>> --- a/debian.ti-omap4/config/config.common.ubuntu
>> +++ b/debian.ti-omap4/config/config.common.ubuntu
>> @@ -1013,7 +1013,7 @@ CONFIG_INET_XFRM_TUNNEL=m
>>   CONFIG_INFTL=m
>>   CONFIG_INITRAMFS_SOURCE=""
>>   CONFIG_INIT_ENV_ARG_LIMIT=32
>> -# CONFIG_INIT_PASS_ALL_PARAMS is not set
>> +CONFIG_INIT_PASS_ALL_PARAMS=y
>>   # CONFIG_INLINE_READ_LOCK is not set
>>   # CONFIG_INLINE_READ_LOCK_BH is not set
>>   # CONFIG_INLINE_READ_LOCK_IRQ is not set
>
>
>

Looks good to me as well.

Acked-by: Brad Figg <brad.figg@canonical.com>

Patch

diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
index fea641e..ff71324 100644
--- a/debian.ti-omap4/config/config.common.ubuntu
+++ b/debian.ti-omap4/config/config.common.ubuntu
@@ -1013,7 +1013,7 @@  CONFIG_INET_XFRM_TUNNEL=m
 CONFIG_INFTL=m
 CONFIG_INITRAMFS_SOURCE=""
 CONFIG_INIT_ENV_ARG_LIMIT=32
-# CONFIG_INIT_PASS_ALL_PARAMS is not set
+CONFIG_INIT_PASS_ALL_PARAMS=y
 # CONFIG_INLINE_READ_LOCK is not set
 # CONFIG_INLINE_READ_LOCK_BH is not set
 # CONFIG_INLINE_READ_LOCK_IRQ is not set