mbox

[PULL,v2,0/6] virtio,pci: fixes and updates

Message ID 1473952956-16264-1-git-send-email-mst@redhat.com
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

Message

Michael S. Tsirkin Sept. 15, 2016, 3:22 p.m. UTC 
The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56:

  fpu: add mechanism to check for invalid long double formats (2016-09-15 12:43:18 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to db86aad1aac8bbb55ed21b554e0b8c7f201bbb46:

  MAINTAINERS: add virtio-* tests (2016-09-15 17:30:04 +0300)

----------------------------------------------------------------
virtio,pci: fixes and updates

AMD IOMMU emulation
virtio feature negotiation rework

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
David Kiarie (4):
      hw/pci: Prepare for AMD IOMMU
      hw/i386/trace-events: Add AMD IOMMU trace events
      hw/i386: Introduce AMD IOMMU
      hw/i386: AMD IOMMU IVRS table

Greg Kurz (1):
      MAINTAINERS: add virtio-* tests

Maxime Coquelin (1):
      virtio-bus: Plug devices after features are negotiated

 hw/i386/amd_iommu.h            |  289 +++++++++
 hw/virtio/virtio-pci.h         |    5 +
 include/hw/acpi/aml-build.h    |    1 +
 include/hw/i386/x86-iommu.h    |   12 +
 include/hw/pci/pci.h           |    4 +-
 include/hw/virtio/virtio-bus.h |   10 +-
 hw/acpi/aml-build.c            |    2 +-
 hw/i386/acpi-build.c           |   76 ++-
 hw/i386/amd_iommu.c            | 1383 ++++++++++++++++++++++++++++++++++++++++
 hw/i386/intel_iommu.c          |    1 +
 hw/i386/x86-iommu.c            |    6 +
 hw/s390x/virtio-ccw.c          |   30 +-
 hw/virtio/virtio-bus.c         |    9 +-
 hw/virtio/virtio-pci.c         |   36 +-
 MAINTAINERS                    |    7 +
 hw/i386/Makefile.objs          |    1 +
 hw/i386/trace-events           |   29 +
 17 files changed, 1862 insertions(+), 39 deletions(-)
 create mode 100644 hw/i386/amd_iommu.h
 create mode 100644 hw/i386/amd_iommu.c

Comments

no-reply@patchew.org Sept. 15, 2016, 4:25 p.m. UTC | #1 
Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1473952956-16264-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6e5404e MAINTAINERS: add virtio-* tests
891e449 hw/i386: AMD IOMMU IVRS table
2e128a0 hw/i386: Introduce AMD IOMMU
6f5a9ae hw/i386/trace-events: Add AMD IOMMU trace events
1ee8f53 hw/pci: Prepare for AMD IOMMU
aa2f6bf virtio-bus: Plug devices after features are negotiated

=== OUTPUT BEGIN ===
Checking PATCH 1/6: virtio-bus: Plug devices after features are negotiated...
Checking PATCH 2/6: hw/pci: Prepare for AMD IOMMU...
Checking PATCH 3/6: hw/i386/trace-events: Add AMD IOMMU trace events...
Checking PATCH 4/6: hw/i386: Introduce AMD IOMMU...
ERROR: struct MemoryRegionIOMMUOps should normally be const
#1707: FILE: hw/i386/amd_iommu.h:280:
+    MemoryRegionIOMMUOps iommu_ops;

total: 1 errors, 0 warnings, 1677 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: hw/i386: AMD IOMMU IVRS table...
Checking PATCH 6/6: MAINTAINERS: add virtio-* tests...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Michael S. Tsirkin Sept. 15, 2016, 4:36 p.m. UTC | #2 
On Thu, Sep 15, 2016 at 09:25:51AM -0700, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
> 
> Your series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 1473952956-16264-1-git-send-email-mst@redhat.com
> Subject: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 6e5404e MAINTAINERS: add virtio-* tests
> 891e449 hw/i386: AMD IOMMU IVRS table
> 2e128a0 hw/i386: Introduce AMD IOMMU
> 6f5a9ae hw/i386/trace-events: Add AMD IOMMU trace events
> 1ee8f53 hw/pci: Prepare for AMD IOMMU
> aa2f6bf virtio-bus: Plug devices after features are negotiated
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/6: virtio-bus: Plug devices after features are negotiated...
> Checking PATCH 2/6: hw/pci: Prepare for AMD IOMMU...
> Checking PATCH 3/6: hw/i386/trace-events: Add AMD IOMMU trace events...
> Checking PATCH 4/6: hw/i386: Introduce AMD IOMMU...
> ERROR: struct MemoryRegionIOMMUOps should normally be const
> #1707: FILE: hw/i386/amd_iommu.h:280:
> +    MemoryRegionIOMMUOps iommu_ops;
> 
> total: 1 errors, 0 warnings, 1677 lines checked

False positive I believe.

> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 5/6: hw/i386: AMD IOMMU IVRS table...
> Checking PATCH 6/6: MAINTAINERS: add virtio-* tests...
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@freelists.org
Peter Maydell Sept. 15, 2016, 6:35 p.m. UTC | #3 
On 15 September 2016 at 16:22, Michael S. Tsirkin <mst@redhat.com> wrote:
> The following changes since commit d1eb8f2acba579830cf3798c3c15ce51be852c56:
>
>   fpu: add mechanism to check for invalid long double formats (2016-09-15 12:43:18 +0100)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to db86aad1aac8bbb55ed21b554e0b8c7f201bbb46:
>
>   MAINTAINERS: add virtio-* tests (2016-09-15 17:30:04 +0300)
>
> ----------------------------------------------------------------
> virtio,pci: fixes and updates
>
> AMD IOMMU emulation
> virtio feature negotiation rework
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Fails to build on PPC64BE:

/home/pm215/qemu/hw/i386/amd_iommu.c:129:1: error: no semicolon at end
of struct or union [-Werror]
 } CMDInvalIommuPages;
 ^
/home/pm215/qemu/hw/i386/amd_iommu.c:245:5: error: expected ‘,’, ‘;’
or ‘}’ before ‘uint32_t’
     uint32_t reserved_3:29;
     ^
/home/pm215/qemu/hw/i386/amd_iommu.c: In function ‘amdvi_complete_ppr’:
/home/pm215/qemu/hw/i386/amd_iommu.c:588:62: error: ‘CMDCompletePPR’
has no member named ‘reserved_3’
     if (pprcomp->reserved_1 || pprcomp->reserved_2 || pprcomp->reserved_3 ||
                                                              ^
/home/pm215/qemu/hw/i386/amd_iommu.c:589:16: error: ‘CMDCompletePPR’
has no member named ‘reserved_4’
         pprcomp->reserved_4 || pprcomp->reserved_5) {
                ^
/home/pm215/qemu/hw/i386/amd_iommu.c:589:39: error: ‘CMDCompletePPR’
has no member named ‘reserved_5’
         pprcomp->reserved_4 || pprcomp->reserved_5) {
                                       ^

Missing semicolon at the end of line 121.

thanks
-- PMM