diff mbox

[linux,dev-4.7,3/3] arm: dts: aspeed: Add SPI1 master pinmux hog to g5 machines

Message ID 20160915111308.31481-3-joel@jms.id.au
State Superseded, archived
Delegated to: Joel Stanley
Headers show

Commit Message

Joel Stanley Sept. 15, 2016, 11:13 a.m. UTC
This is for reuqired for using the PNOR on ast2500 based systems.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-ast2500-evb.dts         | 5 +++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 5 +++++
 2 files changed, 10 insertions(+)

Comments

Andrew Jeffery Sept. 16, 2016, 12:39 a.m. UTC | #1
On Thu, 2016-09-15 at 20:43 +0930, Joel Stanley wrote:
> This is for reuqired for using the PNOR on ast2500 based systems.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

Have we sorted out how we're going to deal with the strap register
configuration (given the pinmux driver treats it as read-only)? I don't
see a u-boot issue for it yet.

Cheers,

Andrew

> ---
>  arch/arm/boot/dts/aspeed-ast2500-evb.dts         | 5 +++++
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-ast2500-evb.dts b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> index d34e6f15a0cb..a517b4a595b8 100644
> --- a/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> @@ -35,6 +35,11 @@
>  	};
>  };
>  
> +&pinctrl {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_spi1_master_default>;
> +};
> +
>  &uart5 {
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index fcc880a80ee0..d7db9700172f 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -36,6 +36,11 @@
>  	};
>  };
>  
> +&pinctrl {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_spi1_master_default>;
> +};
> +
>  &uart5 {
>  	status = "okay";
>  };
Joel Stanley Sept. 16, 2016, 12:51 a.m. UTC | #2
On Fri, Sep 16, 2016 at 10:09 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> On Thu, 2016-09-15 at 20:43 +0930, Joel Stanley wrote:
>> This is for reuqired for using the PNOR on ast2500 based systems.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> Have we sorted out how we're going to deal with the strap register
> configuration (given the pinmux driver treats it as read-only)? I don't
> see a u-boot issue for it yet.

I've opened https://github.com/openbmc/openbmc/issues/579 as I haven't
decided if we want it do it in u-boot, kernel or somewhere else.

Cheers,

Joel
Andrew Jeffery Sept. 16, 2016, 2:22 a.m. UTC | #3
On Fri, 2016-09-16 at 10:21 +0930, Joel Stanley wrote:
> On Fri, Sep 16, 2016 at 10:09 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> > 
> > On Thu, 2016-09-15 at 20:43 +0930, Joel Stanley wrote:
> > > 
> > > This is for reuqired for using the PNOR on ast2500 based systems.
> > > 
> > > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> > 
> > Have we sorted out how we're going to deal with the strap register
> > configuration (given the pinmux driver treats it as read-only)? I don't
> > see a u-boot issue for it yet.
> I've opened https://github.com/openbmc/openbmc/issues/579 as I haven't
> decided if we want it do it in u-boot, kernel or somewhere else.

Fair enough!

Thanks,

Andrew
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-ast2500-evb.dts b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
index d34e6f15a0cb..a517b4a595b8 100644
--- a/arch/arm/boot/dts/aspeed-ast2500-evb.dts
+++ b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
@@ -35,6 +35,11 @@ 
 	};
 };
 
+&pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi1_master_default>;
+};
+
 &uart5 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index fcc880a80ee0..d7db9700172f 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -36,6 +36,11 @@ 
 	};
 };
 
+&pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi1_master_default>;
+};
+
 &uart5 {
 	status = "okay";
 };