| Message ID | 1473874838-13744-1-git-send-email-Eugeniy.Paltsev@synopsys.com |
|---|---|
| State | New |
| Headers | show |
> -----Original Message----- > From: Eugeniy Paltsev [mailto:Eugeniy.Paltsev@synopsys.com] > Sent: Wednesday, September 14, 2016 11:11 PM > To: dmaengine@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Appana Durga Kedareswara Rao > <appanad@xilinx.com>; vinod.koul@intel.com; dan.j.williams@intel.com; > andriy.shevchenko@linux.intel.com; linux-snps-arc@lists.infradead.org; Eugeniy > Paltsev <Eugeniy.Paltsev@synopsys.com> > Subject: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode > > Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter- > gather DMA mode") changes default "dmatest" behavior by changing default > mode from "memcpy" to "scatter-gather". > Now "memcpy" gets back as default mode. > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> Reviewed-by: Kedareswara rao Appana <appanad@xilinx.com> Thanks, Kedar. > --- > drivers/dma/dmatest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index > 53e9728..cf76fc6 100644 > --- a/drivers/dma/dmatest.c > +++ b/drivers/dma/dmatest.c > @@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(sg_buffers, > "Number of scatter gather buffers (default: 1)"); > > -static unsigned int dmatest = 1; > +static unsigned int dmatest; > module_param(dmatest, uint, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(dmatest, > - "dmatest 0-memcpy 1-slave_sg (default: 1)"); > + "dmatest 0-memcpy 1-slave_sg (default: 0)"); > > static unsigned int xor_sources = 3; > module_param(xor_sources, uint, S_IRUGO | S_IWUSR); > -- > 2.5.5
On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote: > Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for > scatter-gather DMA mode") changes default "dmatest" behavior by > changing default mode from "memcpy" to "scatter-gather". > Now "memcpy" gets back as default mode. Applied, thanks
On 09/15/2016 08:48 AM, Vinod Koul wrote: > On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote: >> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for >> scatter-gather DMA mode") changes default "dmatest" behavior by >> changing default mode from "memcpy" to "scatter-gather". >> Now "memcpy" gets back as default mode. > > Applied, thanks > > Did that go into stable? It's breaking the default expected behavior in 4.8 without the fix.
On Tue, Oct 18, 2016 at 11:14:08AM -0700, Dave Jiang wrote: > On 09/15/2016 08:48 AM, Vinod Koul wrote: > > On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote: > >> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for > >> scatter-gather DMA mode") changes default "dmatest" behavior by > >> changing default mode from "memcpy" to "scatter-gather". > >> Now "memcpy" gets back as default mode. > > > > Applied, thanks > > Did that go into stable? It's breaking the default expected behavior in > 4.8 without the fix. No it wasnt, and it should have... I send to stable and lokks like it should applied on 4.7 and 4.8. Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-gather DMA mode") came in 4.7 IIUC.. Thanks
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index 53e9728..cf76fc6 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR); MODULE_PARM_DESC(sg_buffers, "Number of scatter gather buffers (default: 1)"); -static unsigned int dmatest = 1; +static unsigned int dmatest; module_param(dmatest, uint, S_IRUGO | S_IWUSR); MODULE_PARM_DESC(dmatest, - "dmatest 0-memcpy 1-slave_sg (default: 1)"); + "dmatest 0-memcpy 1-slave_sg (default: 0)"); static unsigned int xor_sources = 3; module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-gather DMA mode") changes default "dmatest" behavior by changing default mode from "memcpy" to "scatter-gather". Now "memcpy" gets back as default mode. Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> --- drivers/dma/dmatest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)