Message ID | cover.1473839869.git.mjt@msgid.tls.msk.ru |
---|---|
State | New |
Headers | show |
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1473839869.git.mjt@msgid.tls.msk.ru Subject: [Qemu-devel] [PULL 00/27] Trivial patches for 2016-09-14 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3b5f65f mptsas: change .realize function name 9fc4a5e linux-user/qemu.h: change malloc to g_malloc, free to g_free f5721a5 win32: don't run subprocess tests on Mingw32 platform cf0f0f1 sheepdog: remove useless casts df1254b fw_cfg: remove useless casts 076a4d5 tricore: remove useless cast c3dc4e3 s390x: remove useless cast 6f4ecbe linux-user,s390x: remove useless cast 3c49ba8 coccinelle: add a script to remove useless casts 7df53c0 curl: Operate on zero-length file b55d5ea Remove unused function declarations a4ca535 cpus: update comments d358c0b cpus: rename local variable to meaningful one 4c1a79b timer: update comments f9d3c36 ivshmem: Delete duplicate debug message 5e9e4c5 help: Update help to remove misleading display information 5af5845 sh4: fix broken link to documentation 129bf8c MAINTAINERS: Fix up F: entry bit rot 16a49b4 MAINTAINERS: Add some header files to the PC chipset section cb48c25 MAINTAINERS: Fix wildcard for scsi headers 2cf6e9f MAINTAINERS: Add include/sysemu/cpus.h 5041e4f MAINTAINERS: Add include/hw/sh4/ to SH4 section 88f9770 MAINTAINERS: Add include/hw/tricore/ to TriCore section 0b93c13 MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section c5598e3 ui/console: Fix non-working backspace key in monitor of gtk UI 1ace262 tcg: Remove duplicate header includes f33bd93 Remove remainders of HPPA backend === OUTPUT BEGIN === Checking PATCH 1/27: Remove remainders of HPPA backend... Checking PATCH 2/27: tcg: Remove duplicate header includes... Checking PATCH 3/27: ui/console: Fix non-working backspace key in monitor of gtk UI... Checking PATCH 4/27: MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section... Checking PATCH 5/27: MAINTAINERS: Add include/hw/tricore/ to TriCore section... Checking PATCH 6/27: MAINTAINERS: Add include/hw/sh4/ to SH4 section... Checking PATCH 7/27: MAINTAINERS: Add include/sysemu/cpus.h... Checking PATCH 8/27: MAINTAINERS: Fix wildcard for scsi headers... Checking PATCH 9/27: MAINTAINERS: Add some header files to the PC chipset section... Checking PATCH 10/27: MAINTAINERS: Fix up F: entry bit rot... Checking PATCH 11/27: sh4: fix broken link to documentation... WARNING: line over 80 characters #25: FILE: hw/sh4/shix.c:26: + https://web.archive.org/web/20070917001736/perso.enst.fr/~polti/realisations/shix20 total: 0 errors, 1 warnings, 16 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/27: help: Update help to remove misleading display information... Checking PATCH 13/27: ivshmem: Delete duplicate debug message... Checking PATCH 14/27: timer: update comments... Checking PATCH 15/27: cpus: rename local variable to meaningful one... Checking PATCH 16/27: cpus: update comments... Checking PATCH 17/27: Remove unused function declarations... Checking PATCH 18/27: curl: Operate on zero-length file... Checking PATCH 19/27: coccinelle: add a script to remove useless casts... Checking PATCH 20/27: linux-user,s390x: remove useless cast... Checking PATCH 21/27: s390x: remove useless cast... Checking PATCH 22/27: tricore: remove useless cast... Checking PATCH 23/27: fw_cfg: remove useless casts... ERROR: consider using qemu_strtol in preference to strtol #24: FILE: hw/nvram/fw_cfg.c:183: + boot_splash_time = strtol(p, &p, 10); ERROR: consider using qemu_strtol in preference to strtol #33: FILE: hw/nvram/fw_cfg.c:243: + reboot_timeout = strtol(p, &p, 10); total: 2 errors, 0 warnings, 16 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 24/27: sheepdog: remove useless casts... Checking PATCH 25/27: win32: don't run subprocess tests on Mingw32 platform... Checking PATCH 26/27: linux-user/qemu.h: change malloc to g_malloc, free to g_free... Checking PATCH 27/27: mptsas: change .realize function name... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org