| Message ID | cover.1473839869.git.mjt@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1473839869.git.mjt@msgid.tls.msk.ru
Subject: [Qemu-devel] [PULL 00/27] Trivial patches for 2016-09-14
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3b5f65f mptsas: change .realize function name
9fc4a5e linux-user/qemu.h: change malloc to g_malloc, free to g_free
f5721a5 win32: don't run subprocess tests on Mingw32 platform
cf0f0f1 sheepdog: remove useless casts
df1254b fw_cfg: remove useless casts
076a4d5 tricore: remove useless cast
c3dc4e3 s390x: remove useless cast
6f4ecbe linux-user,s390x: remove useless cast
3c49ba8 coccinelle: add a script to remove useless casts
7df53c0 curl: Operate on zero-length file
b55d5ea Remove unused function declarations
a4ca535 cpus: update comments
d358c0b cpus: rename local variable to meaningful one
4c1a79b timer: update comments
f9d3c36 ivshmem: Delete duplicate debug message
5e9e4c5 help: Update help to remove misleading display information
5af5845 sh4: fix broken link to documentation
129bf8c MAINTAINERS: Fix up F: entry bit rot
16a49b4 MAINTAINERS: Add some header files to the PC chipset section
cb48c25 MAINTAINERS: Fix wildcard for scsi headers
2cf6e9f MAINTAINERS: Add include/sysemu/cpus.h
5041e4f MAINTAINERS: Add include/hw/sh4/ to SH4 section
88f9770 MAINTAINERS: Add include/hw/tricore/ to TriCore section
0b93c13 MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section
c5598e3 ui/console: Fix non-working backspace key in monitor of gtk UI
1ace262 tcg: Remove duplicate header includes
f33bd93 Remove remainders of HPPA backend
=== OUTPUT BEGIN ===
Checking PATCH 1/27: Remove remainders of HPPA backend...
Checking PATCH 2/27: tcg: Remove duplicate header includes...
Checking PATCH 3/27: ui/console: Fix non-working backspace key in monitor of gtk UI...
Checking PATCH 4/27: MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section...
Checking PATCH 5/27: MAINTAINERS: Add include/hw/tricore/ to TriCore section...
Checking PATCH 6/27: MAINTAINERS: Add include/hw/sh4/ to SH4 section...
Checking PATCH 7/27: MAINTAINERS: Add include/sysemu/cpus.h...
Checking PATCH 8/27: MAINTAINERS: Fix wildcard for scsi headers...
Checking PATCH 9/27: MAINTAINERS: Add some header files to the PC chipset section...
Checking PATCH 10/27: MAINTAINERS: Fix up F: entry bit rot...
Checking PATCH 11/27: sh4: fix broken link to documentation...
WARNING: line over 80 characters
#25: FILE: hw/sh4/shix.c:26:
+ https://web.archive.org/web/20070917001736/perso.enst.fr/~polti/realisations/shix20
total: 0 errors, 1 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/27: help: Update help to remove misleading display information...
Checking PATCH 13/27: ivshmem: Delete duplicate debug message...
Checking PATCH 14/27: timer: update comments...
Checking PATCH 15/27: cpus: rename local variable to meaningful one...
Checking PATCH 16/27: cpus: update comments...
Checking PATCH 17/27: Remove unused function declarations...
Checking PATCH 18/27: curl: Operate on zero-length file...
Checking PATCH 19/27: coccinelle: add a script to remove useless casts...
Checking PATCH 20/27: linux-user,s390x: remove useless cast...
Checking PATCH 21/27: s390x: remove useless cast...
Checking PATCH 22/27: tricore: remove useless cast...
Checking PATCH 23/27: fw_cfg: remove useless casts...
ERROR: consider using qemu_strtol in preference to strtol
#24: FILE: hw/nvram/fw_cfg.c:183:
+ boot_splash_time = strtol(p, &p, 10);
ERROR: consider using qemu_strtol in preference to strtol
#33: FILE: hw/nvram/fw_cfg.c:243:
+ reboot_timeout = strtol(p, &p, 10);
total: 2 errors, 0 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/27: sheepdog: remove useless casts...
Checking PATCH 25/27: win32: don't run subprocess tests on Mingw32 platform...
Checking PATCH 26/27: linux-user/qemu.h: change malloc to g_malloc, free to g_free...
Checking PATCH 27/27: mptsas: change .realize function name...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
This is a backlog of all trivial patches accumulated since Jul this year. Not a huge amount for more than a month. Please consider applying. Thanks, /mjt The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2016-09-13 17:55:35 +0100) are available in the git repository at: git://git.corpit.ru/qemu.git tags/trivial-patches-fetch for you to fetch changes up to f3f1ef84774aef77d344b196dea2a09b244b87a1: mptsas: change .realize function name (2016-09-14 10:56:40 +0300) ---------------------------------------------------------------- trivial patches for 2016-09-14 ---------------------------------------------------------------- Cao jin (4): timer: update comments cpus: rename local variable to meaningful one cpus: update comments mptsas: change .realize function name Colin Lord (1): help: Update help to remove misleading display information Eduardo Habkost (1): win32: don't run subprocess tests on Mingw32 platform Ladi Prosek (1): Remove unused function declarations Laurent Vivier (6): coccinelle: add a script to remove useless casts linux-user,s390x: remove useless cast s390x: remove useless cast tricore: remove useless cast fw_cfg: remove useless casts sheepdog: remove useless casts Markus Armbruster (1): MAINTAINERS: Fix up F: entry bit rot Md Haris Iqbal (1): linux-user/qemu.h: change malloc to g_malloc, free to g_free Reda Sallahi (1): sh4: fix broken link to documentation Stefano Dong (董兴水) (1): ivshmem: Delete duplicate debug message Thomas Huth (9): Remove remainders of HPPA backend tcg: Remove duplicate header includes ui/console: Fix non-working backspace key in monitor of gtk UI MAINTAINERS: Add include/hw/unicore32/ to UniCore32 section MAINTAINERS: Add include/hw/tricore/ to TriCore section MAINTAINERS: Add include/hw/sh4/ to SH4 section MAINTAINERS: Add include/sysemu/cpus.h MAINTAINERS: Fix wildcard for scsi headers MAINTAINERS: Add some header files to the PC chipset section Tomáš Golembiovský (1): curl: Operate on zero-length file MAINTAINERS | 26 +- block/curl.c | 25 +- block/qcow2.h | 1 - block/sheepdog.c | 4 +- configure | 7 +- cpus.c | 13 +- disas.c | 2 - disas/Makefile.objs | 1 - disas/hppa.c | 2832 ------------------------------------- disas/sh4.c | 6 - hw/misc/ivshmem.c | 1 - hw/nvram/fw_cfg.c | 4 +- hw/ppc/ppc405.h | 6 - hw/s390x/sclp.c | 2 +- hw/s390x/virtio-ccw.h | 1 - hw/scsi/mptsas.c | 4 +- hw/sh4/shix.c | 2 +- hw/tricore/tricore_testboard.c | 2 +- include/block/block.h | 6 - include/block/block_int.h | 9 - include/hw/arm/pxa.h | 1 - include/hw/bt.h | 2 - include/hw/i386/pc.h | 2 - include/hw/pci-host/spapr.h | 2 - include/hw/pci/pci_bridge.h | 1 - include/hw/pci/pcie_port.h | 1 - include/hw/ppc/ppc4xx.h | 6 - include/hw/ppc/spapr.h | 3 - include/hw/ppc/spapr_vio.h | 4 - include/hw/scsi/scsi.h | 1 - include/hw/virtio/virtio-bus.h | 3 - include/migration/migration.h | 2 - include/net/net.h | 2 - include/qemu/bitmap.h | 4 - include/qemu/timer.h | 19 +- include/qemu/uri.h | 2 - include/sysemu/kvm.h | 2 - include/ui/console.h | 2 - include/ui/input.h | 2 - include/ui/spice-display.h | 2 - linux-user/qemu.h | 4 +- linux-user/signal.c | 2 +- linux-user/syscall_defs.h | 4 +- qemu-options.hx | 38 +- qemu-tech.texi | 3 +- scripts/coccinelle/typecast.cocci | 7 + target-alpha/cpu.h | 1 - target-m68k/cpu.h | 1 - target-ppc/cpu.h | 2 - target-ppc/mmu-hash64.h | 1 - target-s390x/cpu.h | 2 - target-sh4/README.sh4 | 2 +- tcg/tcg.c | 2 - tcg/tcg.h | 2 - tcg/tci/README | 2 +- ui/console.c | 1 + 56 files changed, 93 insertions(+), 2998 deletions(-) delete mode 100644 disas/hppa.c create mode 100644 scripts/coccinelle/typecast.cocci