Message ID | 20160912221631.15812-7-paul.gortmaker@windriver.com |
---|---|
State | New |
Headers | show |
On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > The Kconfig for this file is: > > drivers/gpio/Kconfig:config GPIO_LOONGSON1 > drivers/gpio/Kconfig: tristate "Loongson1 GPIO support" > > ...but however it does not include module.h -- it in turn gets it from > another header (gpio/driver.h) and we'd like to replace that with a > forward delcaration of "struct module;" but if we do, this file will > fail to compile. > > So we fix this first to avoid putting build failures into the bisect > commit history. > > Cc: Keguang Zhang <keguang.zhang@gmail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: linux-mips@linux-mips.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c index 10c09bdd8514..ad0a5958fcd0 100644 --- a/drivers/gpio/gpio-loongson1.c +++ b/drivers/gpio/gpio-loongson1.c @@ -8,6 +8,7 @@ * warranty of any kind, whether express or implied. */ +#include <linux/module.h> #include <linux/gpio/driver.h> #include <linux/platform_device.h>
The Kconfig for this file is: drivers/gpio/Kconfig:config GPIO_LOONGSON1 drivers/gpio/Kconfig: tristate "Loongson1 GPIO support" ...but however it does not include module.h -- it in turn gets it from another header (gpio/driver.h) and we'd like to replace that with a forward delcaration of "struct module;" but if we do, this file will fail to compile. So we fix this first to avoid putting build failures into the bisect commit history. Cc: Keguang Zhang <keguang.zhang@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: linux-mips@linux-mips.org Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/gpio/gpio-loongson1.c | 1 + 1 file changed, 1 insertion(+)